Remove function does not always return a value bugs

7 files changed, 13 insertions, 0 deletions

diff --git a/data/lib/bugzillaDOMFunctions.js b/data/lib/bugzillaDOMFunctions.js
index 0856c67..a69f43c 100644
--- a/data/lib/bugzillaDOMFunctions.js
+++ b/data/lib/bugzillaDOMFunctions.js
@@ -163,6 +163,8 @@ function getOptionTableCell(tableId, label) {
       curLabel = curLabel.replace(cleanLabelRE,"$1");
       return (curLabel === label); // maybe this could be a RE match instead
     }
+
+    return false;
   });
 
   if (ourLine.length > 0) {
diff --git a/data/lib/bzpage.js b/data/lib/bzpage.js
index 1ab6585..b86d369 100644
--- a/data/lib/bzpage.js
+++ b/data/lib/bzpage.js
@@ -404,6 +404,8 @@ function startup() {
       location: window.location.href,
       login: getLogin(),
     }));
+
+    return true;
   }
 }
 
diff --git a/data/lib/collectingMetadata.js b/data/lib/collectingMetadata.js
index de07089..9dee83c 100644
--- a/data/lib/collectingMetadata.js
+++ b/data/lib/collectingMetadata.js
@@ -178,6 +178,8 @@ AttachList.prototype.markBadAttachments = function markBadAttachments() {
       addTextLink(x);
     });
   }
+
+  return true;
 };
 
 AttachList.prototype.getParsedAttachments = function getParsedAttachments() {
diff --git a/data/lib/queries.js b/data/lib/queries.js
index ccb2927..55cb2c0 100644
--- a/data/lib/queries.js
+++ b/data/lib/queries.js
@@ -115,4 +115,5 @@ function queryUpstream(qUpBug) {
   else {
     queryUpstreamCallback(text, qUpBug);
   }
+  return true;
 }
diff --git a/data/lib/util.js b/data/lib/util.js
index 8db19f5..8fefb84 100644
--- a/data/lib/util.js
+++ b/data/lib/util.js
@@ -87,6 +87,7 @@ function getBugNoFromURL(url) {
   if (params && params.id) {
     return params.id;
   }
+  return null;
 }
 
 /**
diff --git a/data/rhlib/rhbzpage.js b/data/rhlib/rhbzpage.js
index ef11d5d..fc46d23 100644
--- a/data/rhlib/rhbzpage.js
+++ b/data/rhlib/rhbzpage.js
@@ -180,6 +180,8 @@ function sendBugUpstream(thgs) {
         textContent.trim(),
       comment: admitMsg + localThings.comments.getAllCommentsText()
     }));
+
+    return true;
   }
 }
 
@@ -389,6 +391,8 @@ function addClosingUpstream() {
   centralCommandDispatch("comment",msgStr);
   centralCommandDispatch("status", "CLOSED");
   centralCommandDispatch("resolution", "UPSTREAM");
+
+  return ;
 }
 
 /**
diff --git a/data/tweaks/bug-page-mod.js b/data/tweaks/bug-page-mod.js
index 59444ea..d65e88e 100644
--- a/data/tweaks/bug-page-mod.js
+++ b/data/tweaks/bug-page-mod.js
@@ -965,6 +965,7 @@ DataStoreCtor.prototype = {
     _ensure: function(entry, obj, val) {
       if (obj.toString().indexOf("[object Storage") >= 0) {
         obj.setItem(entry, val);
+        return true;
       } else {
         if (typeof obj[entry] == "undefined")
           obj[entry]  = val;