diff options
author | Matěj Cepl <mcepl@redhat.com> | 2013-08-05 02:43:51 +0200 |
---|---|---|
committer | Matěj Cepl <mcepl@redhat.com> | 2013-08-05 02:44:40 +0200 |
commit | 88dd0c5c926e1c8ec073d24145586ae11d7645e8 (patch) | |
tree | e0430e3858645854ee95ac217083278c307b8462 | |
parent | 8aef88830a0b66fd5ee4bc540b0eed534cad234e (diff) | |
download | bugzilla-triage-88dd0c5c926e1c8ec073d24145586ae11d7645e8.tar.gz |
Remove function does not always return a value bugs
-rw-r--r-- | .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef/comments/ba6f3f59-7f67-4d6c-bd3b-295845054737/body | 33 | ||||
-rw-r--r-- | .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef/comments/ba6f3f59-7f67-4d6c-bd3b-295845054737/values | 29 | ||||
-rw-r--r-- | .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef/values | 50 | ||||
-rw-r--r-- | .be/id-cache | 4 | ||||
-rw-r--r-- | data/lib/bugzillaDOMFunctions.js | 2 | ||||
-rw-r--r-- | data/lib/bzpage.js | 2 | ||||
-rw-r--r-- | data/lib/collectingMetadata.js | 2 | ||||
-rw-r--r-- | data/lib/queries.js | 1 | ||||
-rw-r--r-- | data/lib/util.js | 1 | ||||
-rw-r--r-- | data/rhlib/rhbzpage.js | 4 | ||||
-rw-r--r-- | data/tweaks/bug-page-mod.js | 1 | ||||
-rw-r--r-- | package.json | 2 | ||||
-rw-r--r-- | update.rdf | 15 |
13 files changed, 144 insertions, 2 deletions
diff --git a/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef/comments/ba6f3f59-7f67-4d6c-bd3b-295845054737/body b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef/comments/ba6f3f59-7f67-4d6c-bd3b-295845054737/body new file mode 100644 index 0000000..24cd893 --- /dev/null +++ b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef/comments/ba6f3f59-7f67-4d6c-bd3b-295845054737/body @@ -0,0 +1,33 @@ +This is depreceated in the strict mode: + +[02:21:12.406] function getBugNoFromURL does not always return a value +data/lib/util.js:85 + +[02:21:12.409] function queryUpstream does not always return a value +data/lib/queries.js:105 + +[02:21:12.410] function markBadAttachments does not always return a value +data/lib/collectingMetadata.js:159 + +[02:21:12.412] anonymous function does not always return a value +data/lib/bugzillaDOMFunctions.js:159 + +[02:21:12.414] function pasteBacktraceInComments does not always return a value +data/rhlib/makeBacktraceAttachment.js:7 + +[02:21:12.417] anonymous function does not always return a value +data/tweaks/bug-page-mod.js:965 + +[02:21:12.419] function sendBugUpstream does not always return a value +data/rhlib/rhbzpage.js:174 + +[02:21:12.419] function sendBugUpstream does not always return a value +data/rhlib/rhbzpage.js:165 + +(isn't function sendBugUpstream duplicated???) + +[02:21:12.419] function addClosingUpstream does not always return a value +data/rhlib/rhbzpage.js:378 + +[02:21:12.420] function startup does not always return a value +data/lib/bzpage.js:358 diff --git a/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef/comments/ba6f3f59-7f67-4d6c-bd3b-295845054737/values b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef/comments/ba6f3f59-7f67-4d6c-bd3b-295845054737/values new file mode 100644 index 0000000..15ff7d9 --- /dev/null +++ b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef/comments/ba6f3f59-7f67-4d6c-bd3b-295845054737/values @@ -0,0 +1,29 @@ +{ + + + + + + + "Author": "Mat\u011bj Cepl <mcepl@redhat.com>", + + + + + + + "Content-type": "text/plain", + + + + + + + "Date": "Mon, 05 Aug 2013 00:29:00 +0000" + + + + + + +} diff --git a/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef/values b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef/values new file mode 100644 index 0000000..7606503 --- /dev/null +++ b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef/values @@ -0,0 +1,50 @@ +{ + + + + + + + "creator": "Mat\u011bj Cepl <mcepl@redhat.com>", + + + + + + + "reporter": "Mat\u011bj Cepl <mcepl@redhat.com>", + + + + + + + "severity": "minor", + + + + + + + "status": "fixed", + + + + + + + "summary": "functions not always return value", + + + + + + + "time": "Mon, 05 Aug 2013 00:28:14 +0000" + + + + + + +} diff --git a/.be/id-cache b/.be/id-cache index 157d9ac..e306f2a 100644 --- a/.be/id-cache +++ b/.be/id-cache @@ -1,5 +1,6 @@ 341b4a39-364e-4a17-bed5-0a5b6adbe87c .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/341b4a39-364e-4a17-bed5-0a5b6adbe87c 4f0b624c-0c53-4dac-a3a6-62c1cf5af9b8 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/eed9233c-63d0-4ba0-bb03-536399864eae/comments/4f0b624c-0c53-4dac-a3a6-62c1cf5af9b8 +ba6f3f59-7f67-4d6c-bd3b-295845054737 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef/comments/ba6f3f59-7f67-4d6c-bd3b-295845054737 ce194c61-2ff0-4d46-adb0-c395f7799d65 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/ce194c61-2ff0-4d46-adb0-c395f7799d65 b1320128-9ce0-4b75-94db-125c0d624177 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/b1320128-9ce0-4b75-94db-125c0d624177 bfd82e6e-6ae6-4fd7-9cd2-9fbb26d629cf .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/341b4a39-364e-4a17-bed5-0a5b6adbe87c/comments/bfd82e6e-6ae6-4fd7-9cd2-9fbb26d629cf @@ -12,5 +13,6 @@ efe0e62b-a48e-4b2e-9fcf-2194e7ca0c18 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bu 359d0ee2-2684-4618-9fab-f7599e2960f4 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/b1320128-9ce0-4b75-94db-125c0d624177/comments/359d0ee2-2684-4618-9fab-f7599e2960f4 930c1804-09a7-4446-bee2-6483985e15da .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/930c1804-09a7-4446-bee2-6483985e15da cc60d077-b549-4f7c-aaac-0f59f91f6f64 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/cc60d077-b549-4f7c-aaac-0f59f91f6f64 -d0aa7120-1df1-4943-8f48-d50884f655c7 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/341b4a39-364e-4a17-bed5-0a5b6adbe87c/comments/d0aa7120-1df1-4943-8f48-d50884f655c7 6f7c63a7-70bc-40b8-bad3-add730fad0fd .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/6f7c63a7-70bc-40b8-bad3-add730fad0fd +d0aa7120-1df1-4943-8f48-d50884f655c7 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/341b4a39-364e-4a17-bed5-0a5b6adbe87c/comments/d0aa7120-1df1-4943-8f48-d50884f655c7 +058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/058f3c3e-9ca2-4c11-a2a9-8bb13c5f9aef diff --git a/data/lib/bugzillaDOMFunctions.js b/data/lib/bugzillaDOMFunctions.js index 0856c67..a69f43c 100644 --- a/data/lib/bugzillaDOMFunctions.js +++ b/data/lib/bugzillaDOMFunctions.js @@ -163,6 +163,8 @@ function getOptionTableCell(tableId, label) { curLabel = curLabel.replace(cleanLabelRE,"$1"); return (curLabel === label); // maybe this could be a RE match instead } + + return false; }); if (ourLine.length > 0) { diff --git a/data/lib/bzpage.js b/data/lib/bzpage.js index 1ab6585..b86d369 100644 --- a/data/lib/bzpage.js +++ b/data/lib/bzpage.js @@ -404,6 +404,8 @@ function startup() { location: window.location.href, login: getLogin(), })); + + return true; } } diff --git a/data/lib/collectingMetadata.js b/data/lib/collectingMetadata.js index de07089..9dee83c 100644 --- a/data/lib/collectingMetadata.js +++ b/data/lib/collectingMetadata.js @@ -178,6 +178,8 @@ AttachList.prototype.markBadAttachments = function markBadAttachments() { addTextLink(x); }); } + + return true; }; AttachList.prototype.getParsedAttachments = function getParsedAttachments() { diff --git a/data/lib/queries.js b/data/lib/queries.js index ccb2927..55cb2c0 100644 --- a/data/lib/queries.js +++ b/data/lib/queries.js @@ -115,4 +115,5 @@ function queryUpstream(qUpBug) { else { queryUpstreamCallback(text, qUpBug); } + return true; } diff --git a/data/lib/util.js b/data/lib/util.js index 8db19f5..8fefb84 100644 --- a/data/lib/util.js +++ b/data/lib/util.js @@ -87,6 +87,7 @@ function getBugNoFromURL(url) { if (params && params.id) { return params.id; } + return null; } /** diff --git a/data/rhlib/rhbzpage.js b/data/rhlib/rhbzpage.js index ef11d5d..fc46d23 100644 --- a/data/rhlib/rhbzpage.js +++ b/data/rhlib/rhbzpage.js @@ -180,6 +180,8 @@ function sendBugUpstream(thgs) { textContent.trim(), comment: admitMsg + localThings.comments.getAllCommentsText() })); + + return true; } } @@ -389,6 +391,8 @@ function addClosingUpstream() { centralCommandDispatch("comment",msgStr); centralCommandDispatch("status", "CLOSED"); centralCommandDispatch("resolution", "UPSTREAM"); + + return ; } /** diff --git a/data/tweaks/bug-page-mod.js b/data/tweaks/bug-page-mod.js index 59444ea..d65e88e 100644 --- a/data/tweaks/bug-page-mod.js +++ b/data/tweaks/bug-page-mod.js @@ -965,6 +965,7 @@ DataStoreCtor.prototype = { _ensure: function(entry, obj, val) { if (obj.toString().indexOf("[object Storage") >= 0) { obj.setItem(entry, val); + return true; } else { if (typeof obj[entry] == "undefined") obj[entry] = val; diff --git a/package.json b/package.json index cc32e26..6ca746e 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "description": "Additional buttons and other function helping in the triage on bugzilla", "author": "Matej Cepl (http://matej.ceplovi.cz)", "license": "MIT/X11 (http://opensource.org/licenses/mit-license.php) and MPL", - "version": "1.7", + "version": "1.7.1", "contributors": [ "Ehsan Akhgari (http://ehsanakhgari.org/) <ehsan@mozilla.com>", "Johnathan Nightingale (http://johnath.com) <johnath@mozilla.com>", @@ -382,6 +382,21 @@ xmlns:em="http://www.mozilla.org/2004/em-rdf#"> </em:targetApplication> </Description> </li> + <li> + <Description> + <em:version>1.7.1</em:version> + <em:targetApplication> + <Description> + <em:id> + {ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id> + <em:minVersion>19.0</em:minVersion> + <em:maxVersion>20.*</em:maxVersion> + <em:updateLink> + https://fedorahosted.org/released/bugzilla-triage-scripts/bugzilla-triage-1.7.1.xpi</em:updateLink> + </Description> + </em:targetApplication> + </Description> + </li> </Seq> </em:updates> </Description> |