aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatěj Cepl <mcepl@redhat.com>2013-08-05 01:58:42 +0200
committerMatěj Cepl <mcepl@redhat.com>2013-08-05 02:18:44 +0200
commit8aef88830a0b66fd5ee4bc540b0eed534cad234e (patch)
tree18c01b068e454f4053e087bf166630ff34d6ba13
parent961b0907b91f9832a5517ade4b2ec35f918a4658 (diff)
downloadbugzilla-triage-8aef88830a0b66fd5ee4bc540b0eed534cad234e.tar.gz
Fix use of RPC calls with Bugzilla 4.4.
-rw-r--r--.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/6f7c63a7-70bc-40b8-bad3-add730fad0fd/body2
-rw-r--r--.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/6f7c63a7-70bc-40b8-bad3-add730fad0fd/values29
-rw-r--r--.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/efe0e62b-a48e-4b2e-9fcf-2194e7ca0c18/body1
-rw-r--r--.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/efe0e62b-a48e-4b2e-9fcf-2194e7ca0c18/values29
-rw-r--r--.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/values2
-rw-r--r--.be/id-cache2
-rw-r--r--data/rhlib/addAttachmentRow.js15
-rw-r--r--data/rhlib/fixingAttMIME.js5
-rw-r--r--data/tweaks/bug-page-mod.js1
-rw-r--r--package.json2
-rw-r--r--update.rdf15
11 files changed, 90 insertions, 13 deletions
diff --git a/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/6f7c63a7-70bc-40b8-bad3-add730fad0fd/body b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/6f7c63a7-70bc-40b8-bad3-add730fad0fd/body
new file mode 100644
index 0000000..ef00aba
--- /dev/null
+++ b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/6f7c63a7-70bc-40b8-bad3-add730fad0fd/body
@@ -0,0 +1,2 @@
+RedHat.addAttachment more or less switched to Bug.add_attachment.
+Hopefully.
diff --git a/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/6f7c63a7-70bc-40b8-bad3-add730fad0fd/values b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/6f7c63a7-70bc-40b8-bad3-add730fad0fd/values
new file mode 100644
index 0000000..dfdd213
--- /dev/null
+++ b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/6f7c63a7-70bc-40b8-bad3-add730fad0fd/values
@@ -0,0 +1,29 @@
+{
+
+
+
+
+
+
+ "Author": "Mat\u011bj Cepl <mcepl@redhat.com>",
+
+
+
+
+
+
+ "Content-type": "text/plain",
+
+
+
+
+
+
+ "Date": "Sun, 04 Aug 2013 23:54:39 +0000"
+
+
+
+
+
+
+}
diff --git a/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/efe0e62b-a48e-4b2e-9fcf-2194e7ca0c18/body b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/efe0e62b-a48e-4b2e-9fcf-2194e7ca0c18/body
new file mode 100644
index 0000000..e997b7b
--- /dev/null
+++ b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/efe0e62b-a48e-4b2e-9fcf-2194e7ca0c18/body
@@ -0,0 +1 @@
+User.login is OK.
diff --git a/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/efe0e62b-a48e-4b2e-9fcf-2194e7ca0c18/values b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/efe0e62b-a48e-4b2e-9fcf-2194e7ca0c18/values
new file mode 100644
index 0000000..843c2a4
--- /dev/null
+++ b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/efe0e62b-a48e-4b2e-9fcf-2194e7ca0c18/values
@@ -0,0 +1,29 @@
+{
+
+
+
+
+
+
+ "Author": "Mat\u011bj Cepl <mcepl@redhat.com>",
+
+
+
+
+
+
+ "Content-type": "text/plain",
+
+
+
+
+
+
+ "Date": "Sun, 04 Aug 2013 23:42:51 +0000"
+
+
+
+
+
+
+}
diff --git a/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/values b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/values
index 01cc9fc..13b4e49 100644
--- a/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/values
+++ b/.be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/values
@@ -26,7 +26,7 @@
- "status": "open",
+ "status": "fixed",
diff --git a/.be/id-cache b/.be/id-cache
index 23d8ef0..157d9ac 100644
--- a/.be/id-cache
+++ b/.be/id-cache
@@ -7,8 +7,10 @@ bfd82e6e-6ae6-4fd7-9cd2-9fbb26d629cf .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bu
eed9233c-63d0-4ba0-bb03-536399864eae .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/eed9233c-63d0-4ba0-bb03-536399864eae
7bb7186a-ba93-43be-bef8-44ff66c5eae4 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/341b4a39-364e-4a17-bed5-0a5b6adbe87c/comments/7bb7186a-ba93-43be-bef8-44ff66c5eae4
739951e1-05d4-4450-b325-bc6144c19571 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571
+efe0e62b-a48e-4b2e-9fcf-2194e7ca0c18 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/efe0e62b-a48e-4b2e-9fcf-2194e7ca0c18
86b4636c-58fc-4101-bffb-322daa03f6a0 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/86b4636c-58fc-4101-bffb-322daa03f6a0
359d0ee2-2684-4618-9fab-f7599e2960f4 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/b1320128-9ce0-4b75-94db-125c0d624177/comments/359d0ee2-2684-4618-9fab-f7599e2960f4
930c1804-09a7-4446-bee2-6483985e15da .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/930c1804-09a7-4446-bee2-6483985e15da
cc60d077-b549-4f7c-aaac-0f59f91f6f64 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/cc60d077-b549-4f7c-aaac-0f59f91f6f64
d0aa7120-1df1-4943-8f48-d50884f655c7 .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/341b4a39-364e-4a17-bed5-0a5b6adbe87c/comments/d0aa7120-1df1-4943-8f48-d50884f655c7
+6f7c63a7-70bc-40b8-bad3-add730fad0fd .be/6e705c50-2e25-43dd-9c06-90e436c2c636/bugs/739951e1-05d4-4450-b325-bc6144c19571/comments/6f7c63a7-70bc-40b8-bad3-add730fad0fd
diff --git a/data/rhlib/addAttachmentRow.js b/data/rhlib/addAttachmentRow.js
index 9baa373..850d417 100644
--- a/data/rhlib/addAttachmentRow.js
+++ b/data/rhlib/addAttachmentRow.js
@@ -5,7 +5,7 @@
// FIXME resp is JSON, not XML anymore
function addAttachmentCallback(resp) {
var newAttachID = parseInt(
- resp.params.param.value.array.data.value.int, 10);
+ resp.params.param.value.array.ids.value.int, 10);
// FIXME callback.call(param, newAttachID, data.length);
}
@@ -42,14 +42,13 @@ function addAttachment(data, callback, param) {
}
var params = {
- id : getBugNo(),
- description : titleParsedAttachment,
- filename : "parsed-backtrace.txt",
- contenttype : "text/plain",
- data : window.btoa(data),
- nomail : true
+ ids : [getBugNo()],
+ summary : titleParsedAttachment,
+ file_name : "parsed-backtrace.txt",
+ content_type : "text/plain",
+ data : window.btoa(data)
};
- makeJSONRPCCall("bugzilla.addAttachment", params, addAttachmentCallback);
+ makeJSONRPCCall("Bug.add_attachment", params, addAttachmentCallback);
reqCounter++;
}
diff --git a/data/rhlib/fixingAttMIME.js b/data/rhlib/fixingAttMIME.js
index 56e10ba..dceb47d 100644
--- a/data/rhlib/fixingAttMIME.js
+++ b/data/rhlib/fixingAttMIME.js
@@ -63,8 +63,8 @@ function fixAttachById(bugId, id, type, email) {
email = 0;
}
- // https://bugzilla.redhat.com/\
- // docs/en/html/api/extensions/compat_xmlrpc/code/webservice.html
+ // https://bugzilla.redhat.com/docs/en/html/api/extensions/RedHat\
+ // /lib/WebService/Bugzilla.html
// test on https://bugzilla.redhat.com/show_bug.cgi?id=485145
var params = {
'id': bugId,
@@ -73,7 +73,6 @@ function fixAttachById(bugId, id, type, email) {
'nomail' : email
};
- // makeJSONRPCCall("bugzilla.updateAttachMimeType", params, XMLRPCcallback);
makeJSONRPCCall("RedHat.updateAttachMimeType", params, XMLRPCcallback);
reqCounter++;
}
diff --git a/data/tweaks/bug-page-mod.js b/data/tweaks/bug-page-mod.js
index d9a1719..59444ea 100644
--- a/data/tweaks/bug-page-mod.js
+++ b/data/tweaks/bug-page-mod.js
@@ -183,6 +183,7 @@ function processHistory(history) {
// preprocessDuplicateMarkers(document, iframe.contentDocument);
/*
+ * FIXME Perhaps not correct in bugzilla 4.4
* This is an example of the history we get: { "version": "1.1", "result": {
* "bugs": [ { "history": [ { "when": "2011-04-04T00:19:04Z", "who":
* "cebbert@redhat.com", "changes": [ { "removed": "", "added":
diff --git a/package.json b/package.json
index 418bb55..cc32e26 100644
--- a/package.json
+++ b/package.json
@@ -4,7 +4,7 @@
"description": "Additional buttons and other function helping in the triage on bugzilla",
"author": "Matej Cepl (http://matej.ceplovi.cz)",
"license": "MIT/X11 (http://opensource.org/licenses/mit-license.php) and MPL",
- "version": "1.6.10",
+ "version": "1.7",
"contributors": [
"Ehsan Akhgari (http://ehsanakhgari.org/) <ehsan@mozilla.com>",
"Johnathan Nightingale (http://johnath.com) <johnath@mozilla.com>",
diff --git a/update.rdf b/update.rdf
index 9c333a7..2e94072 100644
--- a/update.rdf
+++ b/update.rdf
@@ -367,6 +367,21 @@ xmlns:em="http://www.mozilla.org/2004/em-rdf#">
</em:targetApplication>
</Description>
</li>
+ <li>
+ <Description>
+ <em:version>1.7</em:version>
+ <em:targetApplication>
+ <Description>
+ <em:id>
+ {ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
+ <em:minVersion>19.0</em:minVersion>
+ <em:maxVersion>20.*</em:maxVersion>
+ <em:updateLink>
+ https://fedorahosted.org/released/bugzilla-triage-scripts/bugzilla-triage-1.7.xpi</em:updateLink>
+ </Description>
+ </em:targetApplication>
+ </Description>
+ </li>
</Seq>
</em:updates>
</Description>