Make render_emoji_as_string = "both" work with rich_text blocks (#902)

Commit 74da30342e8d328fc085d2158e37afda3b908f2c added support for using
rich_text blocks to format messages. With this change, the use of
replace_string_with_emoji() for text type "emoji" can result in running
the replacement twice as replace_string_with_emoji() is also called as
one of the last steps in SlackMessage.render().

This works fine in the default case when render_emoji_as_string = "",
however render_emoji_as_string = "both" results in output like:

  😄 (😄 (:smile:))

instead of the intended:

  😄 (:smile:)

This excludes blocks rendered earlier in the method from the second
call of replace_string_with_emoji().

1 files changed, 4 insertions, 1 deletions

diff --git a/wee_slack.py b/wee_slack.py
index 84c437f..56944f8 100644
--- a/wee_slack.py
+++ b/wee_slack.py
@@ -3443,7 +3443,10 @@ class SlackMessage(object):
                 ),
             )
 
-        text = replace_string_with_emoji(text)
+        # replace_string_with_emoji() was called on blocks earlier via
+        # unfurl_blocks(), so exclude them here
+        text_to_replace = text[len(blocks_rendered) :]
+        text = text[: len(blocks_rendered)] + replace_string_with_emoji(text_to_replace)
 
         self.message_json["_rendered_text"] = text
         return text