summaryrefslogtreecommitdiffstats
path: root/tbl_data.c
diff options
context:
space:
mode:
authorIngo Schwarze <schwarze@openbsd.org>2015-01-30 17:32:16 +0000
committerIngo Schwarze <schwarze@openbsd.org>2015-01-30 17:32:16 +0000
commitfa0509ac63ac6d0a43a709893722ed6ca5f80611 (patch)
treeff27fe4b98063dd10dbfc48b8d77712105d72c7c /tbl_data.c
parent37b1fa2022515dadb78d40e740849dfc6bd68996 (diff)
downloadmandoc-fa0509ac63ac6d0a43a709893722ed6ca5f80611.tar.gz
Delete the redundant tbl span flags, just inspect the actual data
where needed, which is less fragile. This fixes a subtle NULL pointer access to tp->tbl.cols: Due to a bug in the man(7) parser, the first span of a table can end up in a .TP head, in which case tblcalc() was never called. Found by jsg@ with afl.
Diffstat (limited to 'tbl_data.c')
-rw-r--r--tbl_data.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/tbl_data.c b/tbl_data.c
index 697b9073..b9a57622 100644
--- a/tbl_data.c
+++ b/tbl_data.c
@@ -173,7 +173,6 @@ newspan(struct tbl_node *tbl, int line, struct tbl_row *rp)
if (dp->prev == NULL) {
tbl->first_span = dp;
tbl->current_span = NULL;
- dp->flags |= TBL_SPAN_FIRST;
} else
dp->prev->next = dp;
tbl->last_span = dp;