diff options
author | Ingo Schwarze <schwarze@openbsd.org> | 2019-05-03 18:23:53 +0000 |
---|---|---|
committer | Ingo Schwarze <schwarze@openbsd.org> | 2019-05-03 18:23:53 +0000 |
commit | c5077d0d948740ac34e3edfe0d450cb54e4a57c4 (patch) | |
tree | cfc362f1849ea10ecf1933d0b27bd282a0bb82ba /manpath.c | |
parent | 6e3d81e3a50e53ecbdfdbb0d0cad1a619f6d60df (diff) | |
download | mandoc-c5077d0d948740ac34e3edfe0d450cb54e4a57c4.tar.gz |
when processing unknown output options, prevent passing NULL to printf;
patch from anton@
Diffstat (limited to 'manpath.c')
-rw-r--r-- | manpath.c | 5 |
1 files changed, 3 insertions, 2 deletions
@@ -235,12 +235,13 @@ manconf_output(struct manoutput *conf, const char *cp, int fromfile) "includes", "man", "paper", "style", "indent", "width", "tag", "fragment", "mdoc", "noval", "toc" }; + const size_t ntoks = sizeof(toks) / sizeof(toks[0]); const char *errstr; char *oldval; size_t len, tok; - for (tok = 0; tok < sizeof(toks)/sizeof(toks[0]); tok++) { + for (tok = 0; tok < ntoks; tok++) { len = strlen(toks[tok]); if ( ! strncmp(cp, toks[tok], len) && strchr(" = ", cp[len]) != NULL) { @@ -257,7 +258,7 @@ manconf_output(struct manoutput *conf, const char *cp, int fromfile) warnx("-O %s=?: Missing argument value", toks[tok]); return -1; } - if (tok > 6 && *cp != '\0') { + if (tok > 6 && tok < ntoks && *cp != '\0') { warnx("-O %s: Does not take a value: %s", toks[tok], cp); return -1; } |