summaryrefslogtreecommitdiffstats
path: root/eqn.c
diff options
context:
space:
mode:
authorIngo Schwarze <schwarze@openbsd.org>2017-07-07 17:16:17 +0000
committerIngo Schwarze <schwarze@openbsd.org>2017-07-07 17:16:17 +0000
commited519029e97f517c73fb1093e764d1c8798b75e7 (patch)
treed23478a12a7160ceee97f973bbb4ade17441f93e /eqn.c
parent7231369b8878630439e1847ae7436d3e65c686f4 (diff)
downloadmandoc-ed519029e97f517c73fb1093e764d1c8798b75e7.tar.gz
simplify the eqn_box_makebinary() function by removing the trivial pos
parameter; also minus two lines of code; no functional change
Diffstat (limited to 'eqn.c')
-rw-r--r--eqn.c22
1 files changed, 10 insertions, 12 deletions
diff --git a/eqn.c b/eqn.c
index a97b7fda..db810535 100644
--- a/eqn.c
+++ b/eqn.c
@@ -286,7 +286,7 @@ enum parse_mode {
static struct eqn_box *eqn_box_alloc(struct eqn_node *, struct eqn_box *);
static void eqn_box_free(struct eqn_box *);
static struct eqn_box *eqn_box_makebinary(struct eqn_node *,
- enum eqn_post, struct eqn_box *);
+ struct eqn_box *);
static void eqn_def(struct eqn_node *);
static struct eqn_def *eqn_def_find(struct eqn_node *);
static void eqn_delim(struct eqn_node *);
@@ -541,8 +541,7 @@ eqn_box_alloc(struct eqn_node *ep, struct eqn_box *parent)
* The new EQN_SUBEXPR will have a two-child limit.
*/
static struct eqn_box *
-eqn_box_makebinary(struct eqn_node *ep,
- enum eqn_post pos, struct eqn_box *parent)
+eqn_box_makebinary(struct eqn_node *ep, struct eqn_box *parent)
{
struct eqn_box *b, *newb;
@@ -554,7 +553,6 @@ eqn_box_makebinary(struct eqn_node *ep,
parent->last = b->prev;
b->prev = NULL;
newb = eqn_box_alloc(ep, parent);
- newb->pos = pos;
newb->type = EQN_SUBEXPR;
newb->expectargs = 2;
newb->args = 1;
@@ -669,7 +667,6 @@ eqn_parse(struct eqn_node *ep, struct eqn_box *parent)
const char *cp, *cpn;
char *p;
enum eqn_tok tok;
- enum eqn_post pos;
enum { CCL_LET, CCL_DIG, CCL_PUN } ccl, ccln;
int size;
@@ -728,7 +725,7 @@ next_tok:
cur->type = EQN_TEXT;
cur->text = mandoc_strdup("");
}
- parent = eqn_box_makebinary(ep, EQNPOS_NONE, parent);
+ parent = eqn_box_makebinary(ep, parent);
parent->type = EQN_LIST;
parent->expectargs = 1;
parent->font = EQNFONT_ROMAN;
@@ -865,23 +862,23 @@ next_tok:
parent->pos = EQNPOS_FROMTO;
break;
}
+ parent = eqn_box_makebinary(ep, parent);
switch (tok) {
case EQN_TOK_FROM:
- pos = EQNPOS_FROM;
+ parent->pos = EQNPOS_FROM;
break;
case EQN_TOK_TO:
- pos = EQNPOS_TO;
+ parent->pos = EQNPOS_TO;
break;
case EQN_TOK_SUP:
- pos = EQNPOS_SUP;
+ parent->pos = EQNPOS_SUP;
break;
case EQN_TOK_SUB:
- pos = EQNPOS_SUB;
+ parent->pos = EQNPOS_SUB;
break;
default:
abort();
}
- parent = eqn_box_makebinary(ep, pos, parent);
break;
case EQN_TOK_SQRT:
while (parent->args == parent->expectargs)
@@ -913,7 +910,8 @@ next_tok:
parent = parent->parent;
while (EQN_SUBEXPR == parent->type)
parent = parent->parent;
- parent = eqn_box_makebinary(ep, EQNPOS_OVER, parent);
+ parent = eqn_box_makebinary(ep, parent);
+ parent->pos = EQNPOS_OVER;
break;
case EQN_TOK_RIGHT:
case EQN_TOK_BRACE_CLOSE: