diff options
| author | Robin Jarry <robin@jarry.cc> | 2022-11-23 10:43:44 +0100 |
|---|---|---|
| committer | Robin Jarry <robin@jarry.cc> | 2022-12-02 22:10:44 +0100 |
| commit | 70f46757449c8f24b818f4dfc5dcb87da7e327d6 (patch) | |
| tree | a8650017ccdae1f7a4aebbdf745a0fa4ae2c2286 /worker/types | |
| parent | 3cd69ee953b169cf2e61b70948582df4a75cffc5 (diff) | |
| download | aerc-70f46757449c8f24b818f4dfc5dcb87da7e327d6.tar.gz | |
logging: homogenize levels
The main goal is to ensure that by default, the log file (if configured)
does not grow out of proportions. Most of the logging messages in aerc
are actually for debugging and/or trace purposes.
Define clear rules for logging levels. Enforce these rules everywhere.
After this patch, here is what the log file looks like after starting up
with a single account:
INFO 2022/11/24 20:26:16.147164 aerc.go:176: Starting up version 0.13.0-100-g683981479c60 (go1.18.7 amd64 linux)
INFO 2022/11/24 20:26:17.546448 account.go:254: [work] connected.
Signed-off-by: Robin Jarry <robin@jarry.cc>
Tested-by: Bence Ferdinandy <bence@ferdinandy.com>
Acked-by: Tim Culverhouse <tim@timculverhouse.com>
Diffstat (limited to 'worker/types')
| -rw-r--r-- | worker/types/worker.go | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/worker/types/worker.go b/worker/types/worker.go index d21a46a5..67cb9874 100644 --- a/worker/types/worker.go +++ b/worker/types/worker.go @@ -84,9 +84,9 @@ func (worker *Worker) PostAction(msg WorkerMessage, cb func(msg WorkerMessage)) worker.setId(msg) if resp := msg.InResponseTo(); resp != nil { - logging.Debugf("PostAction %T:%T", msg, resp) + logging.Tracef("PostAction %T:%T", msg, resp) } else { - logging.Debugf("PostAction %T", msg) + logging.Tracef("PostAction %T", msg) } // write to Actions channel without blocking worker.queue(msg) @@ -107,9 +107,9 @@ func (worker *Worker) PostMessage(msg WorkerMessage, msg.setAccount(worker.Name) if resp := msg.InResponseTo(); resp != nil { - logging.Debugf("PostMessage %T:%T", msg, resp) + logging.Tracef("PostMessage %T:%T", msg, resp) } else { - logging.Debugf("PostMessage %T", msg) + logging.Tracef("PostMessage %T", msg) } ui.MsgChannel <- msg @@ -122,9 +122,9 @@ func (worker *Worker) PostMessage(msg WorkerMessage, func (worker *Worker) ProcessMessage(msg WorkerMessage) WorkerMessage { if resp := msg.InResponseTo(); resp != nil { - logging.Debugf("ProcessMessage %T(%d):%T(%d)", msg, msg.getId(), resp, resp.getId()) + logging.Tracef("ProcessMessage %T(%d):%T(%d)", msg, msg.getId(), resp, resp.getId()) } else { - logging.Debugf("ProcessMessage %T(%d)", msg, msg.getId()) + logging.Tracef("ProcessMessage %T(%d)", msg, msg.getId()) } if inResponseTo := msg.InResponseTo(); inResponseTo != nil { worker.Lock() @@ -144,9 +144,9 @@ func (worker *Worker) ProcessMessage(msg WorkerMessage) WorkerMessage { func (worker *Worker) ProcessAction(msg WorkerMessage) WorkerMessage { if resp := msg.InResponseTo(); resp != nil { - logging.Debugf("ProcessAction %T(%d):%T(%d)", msg, msg.getId(), resp, resp.getId()) + logging.Tracef("ProcessAction %T(%d):%T(%d)", msg, msg.getId(), resp, resp.getId()) } else { - logging.Debugf("ProcessAction %T(%d)", msg, msg.getId()) + logging.Tracef("ProcessAction %T(%d)", msg, msg.getId()) } if inResponseTo := msg.InResponseTo(); inResponseTo != nil { worker.Lock() |