diff options
| author | Moritz Poldrack <git@moritz.sh> | 2022-07-31 14:32:48 +0200 |
|---|---|---|
| committer | Robin Jarry <robin@jarry.cc> | 2022-08-04 21:58:01 +0200 |
| commit | 978d35d356e8752bdd272884df48a6289d88b40a (patch) | |
| tree | 3910243e688ef503159d07ce44b22cfea5d6c6fd /worker/notmuch | |
| parent | c882cf9960be691fe55617b87cdfcfbabd5d5557 (diff) | |
| download | aerc-978d35d356e8752bdd272884df48a6289d88b40a.tar.gz | |
lint: homogenize operations and minor fixes (gocritic)
Apply GoDoc comment policy (comments for humans should have a space
after the //; machine-readable comments shouldn't)
Use strings.ReplaceAll instead of strings.Replace when appropriate
Remove if/else chains by replacing them with switches
Use short assignment/increment notation
Replace single case switches with if statements
Combine else and if when appropriate
Signed-off-by: Moritz Poldrack <moritz@poldrack.dev>
Acked-by: Robin Jarry <robin@jarry.cc>
Diffstat (limited to 'worker/notmuch')
| -rw-r--r-- | worker/notmuch/lib/database.go | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/worker/notmuch/lib/database.go b/worker/notmuch/lib/database.go index 780e7ab3..e8a581c6 100644 --- a/worker/notmuch/lib/database.go +++ b/worker/notmuch/lib/database.go @@ -351,11 +351,12 @@ func (db *DB) makeThread(parent *types.Thread, msgs *notmuch.Messages, // We want to return the root node var root *types.Thread - if parent != nil { + switch { + case parent != nil: root = parent - } else if lastSibling != nil { + case lastSibling != nil: root = lastSibling // first iteration has no parent - } else { + default: return nil // we don't have any messages at all } |