From 978d35d356e8752bdd272884df48a6289d88b40a Mon Sep 17 00:00:00 2001 From: Moritz Poldrack Date: Sun, 31 Jul 2022 14:32:48 +0200 Subject: lint: homogenize operations and minor fixes (gocritic) Apply GoDoc comment policy (comments for humans should have a space after the //; machine-readable comments shouldn't) Use strings.ReplaceAll instead of strings.Replace when appropriate Remove if/else chains by replacing them with switches Use short assignment/increment notation Replace single case switches with if statements Combine else and if when appropriate Signed-off-by: Moritz Poldrack Acked-by: Robin Jarry --- worker/notmuch/lib/database.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'worker/notmuch') diff --git a/worker/notmuch/lib/database.go b/worker/notmuch/lib/database.go index 780e7ab3..e8a581c6 100644 --- a/worker/notmuch/lib/database.go +++ b/worker/notmuch/lib/database.go @@ -351,11 +351,12 @@ func (db *DB) makeThread(parent *types.Thread, msgs *notmuch.Messages, // We want to return the root node var root *types.Thread - if parent != nil { + switch { + case parent != nil: root = parent - } else if lastSibling != nil { + case lastSibling != nil: root = lastSibling // first iteration has no parent - } else { + default: return nil // we don't have any messages at all } -- cgit