diff options
author | Moritz Poldrack <git@moritz.sh> | 2022-03-22 09:52:27 +0100 |
---|---|---|
committer | Robin Jarry <robin@jarry.cc> | 2022-03-23 20:56:09 +0100 |
commit | ae83373fa63883f03bd5580ad3937d1e5fa428ed (patch) | |
tree | 12e7bae80292088f7dfed45279fa3bce225743bf /lib | |
parent | feecc09b73e2c904be42f271e0c10574b98a95ea (diff) | |
download | aerc-ae83373fa63883f03bd5580ad3937d1e5fa428ed.tar.gz |
logging: added a log on panic
Since panics still regularly "destroy" the terminal, it is hard to get a
stack trace for panics you do not anticipate. This commit adds a panic
handler that automatically creates a logfile inside the current working
directory.
It has to be added to every goroutine that is started and will repair
the terminal on a panic.
Signed-off-by: Moritz Poldrack <git@moritz.sh>
Acked-by: Robin Jarry <robin@jarry.cc>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/open.go | 4 | ||||
-rw-r--r-- | lib/socket.go | 9 | ||||
-rw-r--r-- | lib/ui/ui.go | 3 |
3 files changed, 15 insertions, 1 deletions
diff --git a/lib/open.go b/lib/open.go index 8a016eb3..f395d13d 100644 --- a/lib/open.go +++ b/lib/open.go @@ -3,6 +3,8 @@ package lib import ( "os/exec" "runtime" + + "git.sr.ht/~rjarry/aerc/logging" ) var openBin string = "xdg-open" @@ -49,6 +51,8 @@ func (xdg *xdgOpen) Start() error { return err } go func() { + defer logging.PanicHandler() + xdg.errCh <- xdg.cmd.Wait() close(xdg.errCh) }() diff --git a/lib/socket.go b/lib/socket.go index 814dce12..ae1ce339 100644 --- a/lib/socket.go +++ b/lib/socket.go @@ -13,6 +13,7 @@ import ( "sync/atomic" "time" + "git.sr.ht/~rjarry/aerc/logging" "github.com/kyoh86/xdg" ) @@ -36,6 +37,8 @@ func StartServer(logger *log.Logger) (*AercServer, error) { } // TODO: stash clients and close them on exit... bleh racey go func() { + defer logging.PanicHandler() + for { conn, err := l.Accept() if err != nil { @@ -44,7 +47,11 @@ func StartServer(logger *log.Logger) (*AercServer, error) { as.logger.Printf("Closing Unix server: %v", err) return } - go as.handleClient(conn) + go func() { + defer logging.PanicHandler() + + as.handleClient(conn) + }() } }() return as, nil diff --git a/lib/ui/ui.go b/lib/ui/ui.go index 66c2a054..b65c06a4 100644 --- a/lib/ui/ui.go +++ b/lib/ui/ui.go @@ -3,6 +3,7 @@ package ui import ( "sync/atomic" + "git.sr.ht/~rjarry/aerc/logging" "github.com/gdamore/tcell/v2" ) @@ -43,6 +44,8 @@ func Initialize(content DrawableInteractive) (*UI, error) { state.exit.Store(false) go func() { + defer logging.PanicHandler() + for !state.ShouldExit() { state.tcEvents <- screen.PollEvent() } |