diff options
| author | Koni Marti <koni.marti@gmail.com> | 2022-07-31 22:37:59 +0200 |
|---|---|---|
| committer | Robin Jarry <robin@jarry.cc> | 2022-08-01 10:37:49 +0200 |
| commit | 5cf81f1cb1e5a1b54dc9421b763b683b6275fb57 (patch) | |
| tree | eb59fc32ee7a1ab37fcfa72af561fc04779b7e57 /lib/ui | |
| parent | 687c4777b553659de51f525ac914d4fa97270245 (diff) | |
| download | aerc-5cf81f1cb1e5a1b54dc9421b763b683b6275fb57.tar.gz | |
autocompletion: fix regression
Commit 27425c15c4b9 ("autocompletion: fix slice out of bounds access")
introduced a regression in the autocompletion that messes up the order
of last entered chars when autocompletion runs.
The ranges for a slice a[low:high] are 0 <= low <= high <= len(a) [0]
To reproduce with the ":cf" command:
1) enter ":c"
2) wait for autocompleteion
3) enter "f"
4) the prompt will now be ":fc"
[0]: https://go.dev/ref/spec#Slice_expressions
Fixes: 27425c15c4b9 ("autocompletion: fix slice out of bounds access")
Signed-off-by: Koni Marti <koni.marti@gmail.com>
Acked-by: Robin Jarry <robin@jarry.cc>
Diffstat (limited to 'lib/ui')
| -rw-r--r-- | lib/ui/textinput.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/ui/textinput.go b/lib/ui/textinput.go index f09ebb43..9d1de963 100644 --- a/lib/ui/textinput.go +++ b/lib/ui/textinput.go @@ -70,8 +70,8 @@ func (ti *TextInput) String() string { } func (ti *TextInput) StringLeft() string { - for ti.index >= len(ti.text) { - ti.index = len(ti.text) - 1 + for ti.index > len(ti.text) { + ti.index = len(ti.text) } return string(ti.text[:ti.index]) } |