diff options
author | Moritz Poldrack <git@moritz.sh> | 2022-07-31 14:32:48 +0200 |
---|---|---|
committer | Robin Jarry <robin@jarry.cc> | 2022-08-04 21:58:01 +0200 |
commit | 978d35d356e8752bdd272884df48a6289d88b40a (patch) | |
tree | 3910243e688ef503159d07ce44b22cfea5d6c6fd /lib/ui/popover.go | |
parent | c882cf9960be691fe55617b87cdfcfbabd5d5557 (diff) | |
download | aerc-978d35d356e8752bdd272884df48a6289d88b40a.tar.gz |
lint: homogenize operations and minor fixes (gocritic)
Apply GoDoc comment policy (comments for humans should have a space
after the //; machine-readable comments shouldn't)
Use strings.ReplaceAll instead of strings.Replace when appropriate
Remove if/else chains by replacing them with switches
Use short assignment/increment notation
Replace single case switches with if statements
Combine else and if when appropriate
Signed-off-by: Moritz Poldrack <moritz@poldrack.dev>
Acked-by: Robin Jarry <robin@jarry.cc>
Diffstat (limited to 'lib/ui/popover.go')
-rw-r--r-- | lib/ui/popover.go | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/lib/ui/popover.go b/lib/ui/popover.go index 7a539de1..8c8c4cda 100644 --- a/lib/ui/popover.go +++ b/lib/ui/popover.go @@ -16,13 +16,14 @@ func (p *Popover) Draw(ctx *Context) { width = ctx.Width() - p.x } - if p.y+p.height+1 < ctx.Height() { + switch { + case p.y+p.height+1 < ctx.Height(): // draw below subcontext = ctx.Subcontext(p.x, p.y+1, width, p.height) - } else if p.y-p.height >= 0 { + case p.y-p.height >= 0: // draw above subcontext = ctx.Subcontext(p.x, p.y-p.height, width, p.height) - } else { + default: // can't fit entirely above or below, so find the largest available // vertical space and shrink to fit if p.y > ctx.Height()-p.y { |