diff options
| author | Moritz Poldrack <git@moritz.sh> | 2022-07-31 14:32:48 +0200 |
|---|---|---|
| committer | Robin Jarry <robin@jarry.cc> | 2022-08-04 21:58:01 +0200 |
| commit | 978d35d356e8752bdd272884df48a6289d88b40a (patch) | |
| tree | 3910243e688ef503159d07ce44b22cfea5d6c6fd /lib/structure_helpers.go | |
| parent | c882cf9960be691fe55617b87cdfcfbabd5d5557 (diff) | |
| download | aerc-978d35d356e8752bdd272884df48a6289d88b40a.tar.gz | |
lint: homogenize operations and minor fixes (gocritic)
Apply GoDoc comment policy (comments for humans should have a space
after the //; machine-readable comments shouldn't)
Use strings.ReplaceAll instead of strings.Replace when appropriate
Remove if/else chains by replacing them with switches
Use short assignment/increment notation
Replace single case switches with if statements
Combine else and if when appropriate
Signed-off-by: Moritz Poldrack <moritz@poldrack.dev>
Acked-by: Robin Jarry <robin@jarry.cc>
Diffstat (limited to 'lib/structure_helpers.go')
| -rw-r--r-- | lib/structure_helpers.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/structure_helpers.go b/lib/structure_helpers.go index 99a77a28..6f25e459 100644 --- a/lib/structure_helpers.go +++ b/lib/structure_helpers.go @@ -8,7 +8,7 @@ import ( func FindPlaintext(bs *models.BodyStructure, path []int) []int { for i, part := range bs.Parts { - cur := append(path, i+1) + cur := append(path, i+1) //nolint:gocritic // intentional append to different slice if strings.ToLower(part.MIMEType) == "text" && strings.ToLower(part.MIMESubType) == "plain" { return cur @@ -24,7 +24,7 @@ func FindPlaintext(bs *models.BodyStructure, path []int) []int { func FindCalendartext(bs *models.BodyStructure, path []int) []int { for i, part := range bs.Parts { - cur := append(path, i+1) + cur := append(path, i+1) //nolint:gocritic // intentional append to different slice if strings.ToLower(part.MIMEType) == "text" && strings.ToLower(part.MIMESubType) == "calendar" { return cur @@ -40,7 +40,7 @@ func FindCalendartext(bs *models.BodyStructure, path []int) []int { func FindFirstNonMultipart(bs *models.BodyStructure, path []int) []int { for i, part := range bs.Parts { - cur := append(path, i+1) + cur := append(path, i+1) //nolint:gocritic // intentional append to different slice mimetype := strings.ToLower(part.MIMEType) if mimetype != "multipart" { return cur @@ -55,7 +55,7 @@ func FindFirstNonMultipart(bs *models.BodyStructure, path []int) []int { func FindAllNonMultipart(bs *models.BodyStructure, path []int, pathlist [][]int) [][]int { for i, part := range bs.Parts { - cur := append(path, i+1) + cur := append(path, i+1) //nolint:gocritic // intentional append to different slice mimetype := strings.ToLower(part.MIMEType) if mimetype != "multipart" { tmp := make([]int, len(cur)) |