colorize: handle spaces in styleset

Avoid failure when the styleset [viewer] section contains spaces:

  ~$ cat foo
  [viewer]
  url.fg = #ffffaf
  url.underline = true
  header.fg = #af87ff
  signature.fg = #af87ff
  diff_meta.fg = #ffffff
  diff_meta.bold = true
  diff_chunk.fg = #00cdcd
  diff_add.fg = #00cd00
  diff_del.fg = #cd0000
  quote_1.fg = #5fafff
  quote_2.fg = #ff8700
  quote_3.fg = #af87ff
  quote_4.fg = #ff5fd7
  quote_x.fg = #808080
  ~$ ./colorize -s foo < bar.eml
  error: invalid style attribute 'fg '

Be more restrictive with what characters are part of a style attribute.

Add test styleset with as much weirdness as possible. Update vectors
accordingly. Update sendemail-validate hook to export pedantic CFLAGS.

Reported-by: Tristan Partin <tristan@partin.io>
Signed-off-by: Robin Jarry <robin@jarry.cc>
Reviewed-by: Tristan Partin <tristan@partin.io>
Tested-by: Tristan Partin <tristan@partin.io>

1 files changed, 2 insertions, 0 deletions

diff --git a/contrib/sendemail-validate b/contrib/sendemail-validate
index 35b7d9e3..7df38e05 100755
--- a/contrib/sendemail-validate
+++ b/contrib/sendemail-validate
@@ -30,6 +30,8 @@ validate_patch () {
 	git am -3 "$file"
 }
 
+export CFLAGS="-O2 -g -Wall -Wextra -Wconversion -Warith-conversion -Werror -Wformat-security -Wstack-protector -fstack-protector-strong -fanalyzer"
+
 validate_series () {
 	make all tests lint check-patches
 }