diff options
| author | Moritz Poldrack <git@moritz.sh> | 2022-07-31 14:32:48 +0200 |
|---|---|---|
| committer | Robin Jarry <robin@jarry.cc> | 2022-08-04 21:58:01 +0200 |
| commit | 978d35d356e8752bdd272884df48a6289d88b40a (patch) | |
| tree | 3910243e688ef503159d07ce44b22cfea5d6c6fd /completer | |
| parent | c882cf9960be691fe55617b87cdfcfbabd5d5557 (diff) | |
| download | aerc-978d35d356e8752bdd272884df48a6289d88b40a.tar.gz | |
lint: homogenize operations and minor fixes (gocritic)
Apply GoDoc comment policy (comments for humans should have a space
after the //; machine-readable comments shouldn't)
Use strings.ReplaceAll instead of strings.Replace when appropriate
Remove if/else chains by replacing them with switches
Use short assignment/increment notation
Replace single case switches with if statements
Combine else and if when appropriate
Signed-off-by: Moritz Poldrack <moritz@poldrack.dev>
Acked-by: Robin Jarry <robin@jarry.cc>
Diffstat (limited to 'completer')
| -rw-r--r-- | completer/completer.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/completer/completer.go b/completer/completer.go index 4a65ca7d..c5624f9d 100644 --- a/completer/completer.go +++ b/completer/completer.go @@ -127,7 +127,7 @@ func (c *Completer) getAddressCmd(s string) (*exec.Cmd, error) { if strings.TrimSpace(c.AddressBookCmd) == "" { return nil, fmt.Errorf("no command configured") } - queryCmd := strings.Replace(c.AddressBookCmd, "%s", s, -1) + queryCmd := strings.ReplaceAll(c.AddressBookCmd, "%s", s) parts, err := shlex.Split(queryCmd) if err != nil { return nil, fmt.Errorf("could not lex command") |