app: export global functions

The single Aerc object is passed around in almost all command functions.
This hinders readability.

Store the single Aerc instance as a global variable. Export public
functions from the app package to access methods of that object. Remove
all explicit references to *app.Aerc and replace them with calls to
these functions. For references to private/unexported fields and
functions from within the app package, directly access the global aerc
object.

Signed-off-by: Robin Jarry <robin@jarry.cc>
Acked-by: Moritz Poldrack <moritz@poldrack.dev>

1 files changed, 5 insertions, 5 deletions

diff --git a/commands/next-tab.go b/commands/next-tab.go
index 247e7534..eb7b1ed1 100644
--- a/commands/next-tab.go
+++ b/commands/next-tab.go
@@ -17,11 +17,11 @@ func (NextPrevTab) Aliases() []string {
 	return []string{"next-tab", "prev-tab"}
 }
 
-func (NextPrevTab) Complete(aerc *app.Aerc, args []string) []string {
+func (NextPrevTab) Complete(args []string) []string {
 	return nil
 }
 
-func (NextPrevTab) Execute(aerc *app.Aerc, args []string) error {
+func (NextPrevTab) Execute(args []string) error {
 	if len(args) > 2 {
 		return nextPrevTabUsage(args[0])
 	}
@@ -37,12 +37,12 @@ func (NextPrevTab) Execute(aerc *app.Aerc, args []string) error {
 	}
 	for ; n > 0; n-- {
 		if args[0] == "prev-tab" {
-			aerc.PrevTab()
+			app.PrevTab()
 		} else {
-			aerc.NextTab()
+			app.NextTab()
 		}
 	}
-	aerc.UpdateStatus()
+	app.UpdateStatus()
 	return nil
 }