aboutsummaryrefslogtreecommitdiffstats
path: root/commands/choose.go
diff options
context:
space:
mode:
authorRobin Jarry <robin@jarry.cc>2023-09-19 22:51:49 +0200
committerRobin Jarry <robin@jarry.cc>2023-10-28 19:24:40 +0200
commitb336a5c9e19adba31bec1da51e093a11e09a8ead (patch)
tree4ab356b699472e7fa9e1f2445b499f6b1d0ec039 /commands/choose.go
parenta2a692e7736ef82627eae885d17024d92e33cb4a (diff)
downloadaerc-b336a5c9e19adba31bec1da51e093a11e09a8ead.tar.gz
commands: pass raw command line down to template evaluation
Some commands need to invoke others and/or run shell commands. For this, we need the raw command line as entered by the user. Pass it down the call chain just before it is split to invoke the command Execute method. Remove unit tests for the template expand() test which does have any added value now that it is performed on a single string without any quote juggling. Update all code to handle a single string instead of a list of arguments. Introduce a new dependency on git.sr.ht/~rjarry/go-opt to deal with shell splitting. This is in preparation for using opt.ArgsToStruct to parse arguments for all aerc commands. There should be no functional change after this patch. Signed-off-by: Robin Jarry <robin@jarry.cc> Reviewed-by: Koni Marti <koni.marti@gmail.com> Tested-by: Moritz Poldrack <moritz@poldrack.dev> Tested-by: Inwit <inwit@sindominio.net>
Diffstat (limited to 'commands/choose.go')
-rw-r--r--commands/choose.go3
1 files changed, 1 insertions, 2 deletions
diff --git a/commands/choose.go b/commands/choose.go
index 3f1410cf..6810ed1f 100644
--- a/commands/choose.go
+++ b/commands/choose.go
@@ -2,7 +2,6 @@ package commands
import (
"fmt"
- "strings"
"git.sr.ht/~rjarry/aerc/app"
)
@@ -34,7 +33,7 @@ func (Choose) Execute(args []string) error {
choices = append(choices, app.Choice{
Key: args[i+2],
Text: args[i+3],
- Command: strings.Split(args[i+4], " "),
+ Command: args[i+4],
})
}