app: export global functions

The single Aerc object is passed around in almost all command functions.
This hinders readability.

Store the single Aerc instance as a global variable. Export public
functions from the app package to access methods of that object. Remove
all explicit references to *app.Aerc and replace them with calls to
these functions. For references to private/unexported fields and
functions from within the app package, directly access the global aerc
object.

Signed-off-by: Robin Jarry <robin@jarry.cc>
Acked-by: Moritz Poldrack <moritz@poldrack.dev>

1 files changed, 6 insertions, 6 deletions

diff --git a/commands/account/split.go b/commands/account/split.go
index 82870d60..ddc79e2f 100644
--- a/commands/account/split.go
+++ b/commands/account/split.go
@@ -18,28 +18,28 @@ func (Split) Aliases() []string {
 	return []string{"split", "vsplit"}
 }
 
-func (Split) Complete(aerc *app.Aerc, args []string) []string {
+func (Split) Complete(args []string) []string {
 	return nil
 }
 
-func (Split) Execute(aerc *app.Aerc, args []string) error {
+func (Split) Execute(args []string) error {
 	if len(args) > 2 {
 		return errors.New("Usage: [v]split n")
 	}
-	acct := aerc.SelectedAccount()
+	acct := app.SelectedAccount()
 	if acct == nil {
 		return errors.New("No account selected")
 	}
-	store := aerc.SelectedAccount().Store()
+	store := app.SelectedAccount().Store()
 	if store == nil {
 		return errors.New("Cannot perform action. Messages still loading")
 	}
 	n := 0
 	if acct.SplitSize() == 0 {
 		if args[0] == "split" {
-			n = aerc.SelectedAccount().Messages().Height() / 4
+			n = app.SelectedAccount().Messages().Height() / 4
 		} else {
-			n = aerc.SelectedAccount().Messages().Width() / 2
+			n = app.SelectedAccount().Messages().Width() / 2
 		}
 	}