diff options
| author | Robin Jarry <robin@jarry.cc> | 2024-04-13 21:15:56 +0200 |
|---|---|---|
| committer | Robin Jarry <robin@jarry.cc> | 2024-04-13 21:47:50 +0200 |
| commit | 1b912fbbe98ae9b0a78da2b448f6121944d9b9b1 (patch) | |
| tree | a86d8b0d4909d7abff4d96e75ec8151c57d4b430 /app | |
| parent | 535e7fe3aa50dc56af6449673d13ca0c0ac4e961 (diff) | |
| download | aerc-1b912fbbe98ae9b0a78da2b448f6121944d9b9b1.tar.gz | |
compose: explicitly identify converted text/* parts
When running :accept, an error is displayed on the review screen:
text/calendar error: no command defined for mime/type
When running :multipart text/xxx, its contents are not specified. They
are regenerated every time the review screen is displayed. When running
:accept, a text/calendar part is added with actual contents.
Update the Part object to hold a boolean initialized when first being
created. If body is nil, identify the part as "Converted" and update its
contents every time the review screen is displayed. When body is not nil
but contains text (e.g. when running :accept), identify the part as
*not* converted and ignore the conversion step.
Fixes: cbcabfafaab2 ("compose: allow writing multipart/alternative messages")
Reported-by: Inwit <inwit@sindominio.net>
Signed-off-by: Robin Jarry <robin@jarry.cc>
Tested-by: Inwit <inwit@sindominio.net>
Diffstat (limited to 'app')
| -rw-r--r-- | app/compose.go | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/app/compose.go b/app/compose.go index 22d862aa..9f9ebf39 100644 --- a/app/compose.go +++ b/app/compose.go @@ -1787,7 +1787,10 @@ func (c *Composer) updateMultipart(p *lib.Part) error { p.ConversionError = e return e } - + if !p.Converted { + // text/* multipart created without a command (e.g. by :accept) + return nil + } command, found := config.Converters[p.MimeType] if !found { // unreachable |