diff options
| author | Johannes Thyssen Tishman <johannes@thyssentishman.com> | 2024-01-22 22:03:47 +0100 |
|---|---|---|
| committer | Robin Jarry <robin@jarry.cc> | 2024-01-25 21:54:59 +0100 |
| commit | 3452c9233f623c4049098b66911ae82fc14e119c (patch) | |
| tree | 37b6bbceb851fef84131c5a7e226889675bfc5f2 | |
| parent | 045b4cdc15c4c5ff2f34a3629c6db68a2ce91b72 (diff) | |
| download | aerc-3452c9233f623c4049098b66911ae82fc14e119c.tar.gz | |
check-patches: fix non-posix regex
The usage of '+' to match 'one or more occurrences' of a regex is only
POSIX compliant when used in an Extended Regular Expression (ERE).
Link: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html
Signed-off-by: Johannes Thyssen Tishman <johannes@thyssentishman.com>
Acked-by: Robin Jarry <robin@jarry.cc>
| -rwxr-xr-x | contrib/check-patches | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/contrib/check-patches b/contrib/check-patches index e175b32c..6ae20efb 100755 --- a/contrib/check-patches +++ b/contrib/check-patches @@ -50,7 +50,7 @@ for rev in $revisions; do err "title is longer than 72 characters, please make it shorter" fi - if ! echo "$title" | grep -q '^[a-z0-9,{}/_-]\+: '; then + if ! echo "$title" | grep -qE '^[a-z0-9,{}/_-]+: '; then err "title lacks a topic prefix (e.g. 'imap:')" fi @@ -67,8 +67,8 @@ for rev in $revisions; do done if git log --format="%(trailers:only,unfold)" -1 "$rev" | \ - grep -v '^Changelog-[a-z]\+: [A-Z`\*_].\+\.$' | \ - grep -q '^Changelog-[a-z]\+: '; then + grep -vE '^Changelog-[a-z]+: [A-Z`\*_].+\.$' | \ + grep -qE '^Changelog-[a-z]+: '; then err "Changelog-* trailers should start with a capital letter and end with a period" fi |