diff options
author | Jake Hunsaker <jhunsake@redhat.com> | 2020-03-26 13:58:30 -0400 |
---|---|---|
committer | Jake Hunsaker <jhunsake@redhat.com> | 2020-04-08 09:27:16 -0400 |
commit | 6dabc82e085e418e69db8cd03fc56fd9c8759351 (patch) | |
tree | 96faeb9a7997fdc5ef121c86b38047c8bc5bcd3f /tests | |
parent | c3564f451919bf0de79db6f32e2684bd6c54135c (diff) | |
download | sos-6dabc82e085e418e69db8cd03fc56fd9c8759351.tar.gz |
[options] Update option loading from config file
As we are moving to decouple SoSOptions() from report, we need to adjust
how some of the option loading is handled, such as loading values from a
conf file. The previous approach was to instantiate a new SoSOptions()
object, read into it from the config file, and then merge that with the
"main" SoSOptions() object. This worked well when we only had report to
worry about since the arguments were more or less static.
However, in allowing new subcommands to define their own options this
presented a problem due to the behavior of merging. This was compounded
by the fact that merging still functioned how we expected/needed for
actions like merging commandline options against the defaults.
As such, the new approach is to use the "main" SoSOptions() instance to
read the config file specifications and then directly modify the needed
values rather than relying on the merging behavior.
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Diffstat (limited to 'tests')
0 files changed, 0 insertions, 0 deletions