[testing] Add most testing via tox.ini

Consolidate testing, so that things can be run from CLI, CI and
various other means in a consistent way by using tox.

* Updated all the flake8 tests in the tests folder.
* Added pylint as a neutral test so that we can work on this in stages
  and have some collaboration on what we test and don't
* The tox tests for unit, stageone, stagetwo testing makes is easier
  for users to know how to run tests, and not have to do things
  manually
* Using tox for CI doesn't make sense, as that will create virtual
  envs and will disregard system/snap based python modules so may not
  work

Signed-off-by: Arif Ali <arif.ali@canonical.com>

1 files changed, 5 insertions, 2 deletions

diff --git a/tests/report_tests/plugin_tests/defaults.py b/tests/report_tests/plugin_tests/defaults.py
index 4cdaabd4..4d790114 100644
--- a/tests/report_tests/plugin_tests/defaults.py
+++ b/tests/report_tests/plugin_tests/defaults.py
@@ -31,7 +31,8 @@ class DefaultCollectionsTest(StageTwoReportTest):
         assert ent, "No manifest entry for systemctl status cups"
 
     def test_journal_collected(self):
-        self.assertFileCollected('sos_commands/cups/journalctl_--no-pager_--unit_cups')
+        self.assertFileCollected('sos_commands/cups/journalctl_--no-pager_'
+                                 '--unit_cups')
         _m = self.get_plugin_manifest('cups')
         ent = None
         for cmd in _m['commands']:
@@ -39,4 +40,6 @@ class DefaultCollectionsTest(StageTwoReportTest):
                 ent = cmd
         assert ent, "No manifest entry for journalctl cups"
 
-        assert 'journal_cups' in ent['tags'], "Journal tags not correct: %s" % ent['tags']
+        assert \
+            'journal_cups' in ent['tags'], \
+            f"Journal tags not correct: {ent['tags']}"