diff options
| author | Pavel Moravec <pmoravec@redhat.com> | 2023-06-23 14:34:40 +0200 |
|---|---|---|
| committer | Jake Hunsaker <jacob.r.hunsaker@gmail.com> | 2023-06-27 11:12:13 -0400 |
| commit | 2aec59914031d0f2b59f658243b9b0c49c8e5b13 (patch) | |
| tree | bacc9ababf9fabe6625199e32796994b7161d323 | |
| parent | 291eea59e43293361ad6748037275d310f0e3e85 (diff) | |
| download | sos-2aec59914031d0f2b59f658243b9b0c49c8e5b13.tar.gz | |
[tests] Make options_tests faster by calling them on a few plugins only
options_tests.py tests -n option which means tens of plugins are
redundantly collected. Testing -o option is effectively the same while
the sosreport run needs a half time only.
The functionality of -n option is tested elsewhere, thus the change does
not shrink test coverage.
Resolves: #3288
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
| -rw-r--r-- | tests/report_tests/options_tests/options_tests.py | 6 | ||||
| -rw-r--r-- | tests/report_tests/options_tests/options_tests_sos.conf | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/tests/report_tests/options_tests/options_tests.py b/tests/report_tests/options_tests/options_tests.py index f8e1ee60..997042ba 100644 --- a/tests/report_tests/options_tests/options_tests.py +++ b/tests/report_tests/options_tests/options_tests.py @@ -22,8 +22,8 @@ class OptionsFromConfigTest(StageTwoReportTest): def test_case_id_from_config(self): self.assertTrue('8675309' in self.archive) - def test_plugins_skipped_from_config(self): - self.assertPluginNotIncluded(['networking', 'logs']) + def test_plugins_only_from_config(self): + self.assertOnlyPluginsIncluded(['host', 'kernel']) def test_plugopts_logged_from_config(self): self.assertSosLogContains( @@ -41,5 +41,5 @@ class OptionsFromConfigTest(StageTwoReportTest): def test_effective_options_logged_correctly(self): self.assertSosLogContains( - "effective options now: --batch --case-id 8675309 --plugopts kernel.with-timer=on,kernel.trace=yes --skip-plugins networking,logs" + "effective options now: --batch --case-id 8675309 --only-plugins host,kernel --plugopts kernel.with-timer=on,kernel.trace=yes" ) diff --git a/tests/report_tests/options_tests/options_tests_sos.conf b/tests/report_tests/options_tests/options_tests_sos.conf index c0f641d9..fd92d700 100644 --- a/tests/report_tests/options_tests/options_tests_sos.conf +++ b/tests/report_tests/options_tests/options_tests_sos.conf @@ -2,7 +2,7 @@ #verbose = 3 [report] -skip-plugins = networking,logs +only-plugins = host,kernel case-id = 8675309 [collect] |