diff options
author | Jake Hunsaker <jhunsake@redhat.com> | 2021-05-11 22:44:57 -0400 |
---|---|---|
committer | Jake Hunsaker <jhunsake@redhat.com> | 2021-05-14 10:32:33 -0400 |
commit | 63817ba9dae2cb64b21ab59279def64572a6459a (patch) | |
tree | 11e20f140967c783892952160445962388f31d7e /.gitignore | |
parent | acf0ec6cb49156c0b33c9d578df91fedff543bc7 (diff) | |
download | sos-63817ba9dae2cb64b21ab59279def64572a6459a.tar.gz |
[Policy] Correct and clarify https upload internals
The python requests module does not provide actual support for
streaming, that is provided by requests-toolchain. The support in
requests is for easy multipart uploads. The internal methods and
variables for https uploads within `Policy` however revolve around
streaming enablement, but don't actually influence the use of streaming
or not. This was due to placeholders during development just being
carried forward rather than corrected before merge.
This was largely forgotten about, until recent reports of upload issues
for user-provided endpoints.
This commit serves to correct the language around the currently
supported https upload functionality. That is, we either use a 'put' or
'post' based on the loaded policy defaults. Further, allow users to
control this setting with a new `--upload-method` option. This will
allow users to specify upload urls that may require the opposite HTTP
method than what the policy defaults dictate.
Related: #2497
Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions