diff options
author | Andrew Pollock <apollock@google.com> | 2023-05-02 21:05:24 +1000 |
---|---|---|
committer | Andrew Pollock <apollock@google.com> | 2023-05-12 10:32:08 +1000 |
commit | f47bb2d633347913d5575a42e25872c38569a4a3 (patch) | |
tree | 49d2a6929657cbacac898619a4c3b31e46a26119 /remote.go | |
parent | dc2b346ed149080199d578f0190f3ac1156480c2 (diff) | |
download | go-git-f47bb2d633347913d5575a42e25872c38569a4a3.tar.gz |
git: remote, add support for a configurable timeout.
The previous hard-coded 10 second value is too short for listing large
repositories like https://gitlab.com/gitlab-org/gitlab
Return an error on nonsensical subzero timeout values
Diffstat (limited to 'remote.go')
-rw-r--r-- | remote.go | 10 |
1 files changed, 9 insertions, 1 deletions
@@ -1258,7 +1258,15 @@ func (r *Remote) ListContext(ctx context.Context, o *ListOptions) (rfs []*plumbi } func (r *Remote) List(o *ListOptions) (rfs []*plumbing.Reference, err error) { - ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second) + timeout := o.Timeout + // Default to the old hardcoded 10s value if a timeout is not explicitly set. + if timeout == 0 { + timeout = 10 + } + if timeout < 0 { + return nil, fmt.Errorf("invalid timeout: %d", timeout) + } + ctx, cancel := context.WithTimeout(context.Background(), time.Duration(timeout)*time.Second) defer cancel() return r.ListContext(ctx, o) } |