aboutsummaryrefslogtreecommitdiffstats
path: root/plumbing
diff options
context:
space:
mode:
authorAdrian Pronk <private>2021-07-24 12:40:14 +1200
committerAdrian Pronk <private>2021-07-24 12:40:14 +1200
commit9acce5071f2093d02eb8a485fbe2c8ff6e92c958 (patch)
treeabe01d85df2c53b4e901eab3632cd5b9b453cfcb /plumbing
parentb4368b2a2ca4103b1ff4e37c34a963127342747e (diff)
downloadgo-git-9acce5071f2093d02eb8a485fbe2c8ff6e92c958.tar.gz
plumbing: config, Branch name with hash can be cloned. Fixes #309
Diffstat (limited to 'plumbing')
-rw-r--r--plumbing/format/config/encoder.go2
-rw-r--r--plumbing/format/config/fixtures_test.go18
2 files changed, 19 insertions, 1 deletions
diff --git a/plumbing/format/config/encoder.go b/plumbing/format/config/encoder.go
index 4eac896..93dad1a 100644
--- a/plumbing/format/config/encoder.go
+++ b/plumbing/format/config/encoder.go
@@ -59,7 +59,7 @@ func (e *Encoder) encodeSubsection(sectionName string, s *Subsection) error {
func (e *Encoder) encodeOptions(opts Options) error {
for _, o := range opts {
pattern := "\t%s = %s\n"
- if strings.Contains(o.Value, "\\") {
+ if strings.ContainsAny(o.Value, `"#\"`) || strings.HasPrefix(o.Value, " ") || strings.HasSuffix(o.Value, " ") {
pattern = "\t%s = %q\n"
}
diff --git a/plumbing/format/config/fixtures_test.go b/plumbing/format/config/fixtures_test.go
index f3533df..3255213 100644
--- a/plumbing/format/config/fixtures_test.go
+++ b/plumbing/format/config/fixtures_test.go
@@ -43,6 +43,24 @@ var fixtures = []*Fixture{
Config: New().AddOption("core", "", "repositoryformatversion", "0"),
},
{
+ Raw: "[section]\n",
+ Text: `[section]
+ option1 = "has # hash"
+ option2 = "has \" quote"
+ option3 = "has \\ backslash"
+ option4 = " has leading spaces"
+ option5 = "has trailing spaces "
+ option6 = has no special characters
+`,
+ Config: New().
+ AddOption("section", "", "option1", `has # hash`).
+ AddOption("section", "", "option2", `has " quote`).
+ AddOption("section", "", "option3", `has \ backslash`).
+ AddOption("section", "", "option4", ` has leading spaces`).
+ AddOption("section", "", "option5", `has trailing spaces `).
+ AddOption("section", "", "option6", `has no special characters`),
+ },
+ {
Raw: `
[sect1]
opt1 = value1