diff options
| author | Jeremy Stribling <strib@alum.mit.edu> | 2017-08-21 17:07:01 -0700 |
|---|---|---|
| committer | Jeremy Stribling <strib@alum.mit.edu> | 2017-08-27 17:25:16 -0700 |
| commit | aad08e631b47fb9590a5102159794db42ac4dade (patch) | |
| tree | 267de84ef91b276284ba1ec2bef96e3f0885a0c2 /plumbing/transport/file | |
| parent | 631a45f55b397090ad7d817a3c72041cfc3729f3 (diff) | |
| download | go-git-aad08e631b47fb9590a5102159794db42ac4dade.tar.gz | |
plumbing: use LookPath instead of Stat to fix Windows executables
When git-core isn't in the user's PATH, we need to use `LookPath` to
verify the existence of the executable, rather than `os.Stat`, so that
on Windows it will search for files with executable suffixes.
Diffstat (limited to 'plumbing/transport/file')
| -rw-r--r-- | plumbing/transport/file/client.go | 2 | ||||
| -rw-r--r-- | plumbing/transport/file/client_test.go | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/plumbing/transport/file/client.go b/plumbing/transport/file/client.go index af4a88b..d229fdd 100644 --- a/plumbing/transport/file/client.go +++ b/plumbing/transport/file/client.go @@ -66,7 +66,7 @@ func prefixExecPath(cmd string) (string, error) { cmd = filepath.Join(execPath, cmd) // Make sure it actually exists. - _, err = os.Stat(cmd) + _, err = exec.LookPath(cmd) if err != nil { return "", err } diff --git a/plumbing/transport/file/client_test.go b/plumbing/transport/file/client_test.go index 3532a4c..864cddc 100644 --- a/plumbing/transport/file/client_test.go +++ b/plumbing/transport/file/client_test.go @@ -33,7 +33,7 @@ func (s *ClientSuite) TestCommand(c *C) { // Make sure we get an error for one that doesn't exist. _, err = runner.Command("git-fake-command", ep, emptyAuth) - c.Assert(os.IsNotExist(err), Equals, true) + c.Assert(err, NotNil) } const bareConfig = `[core] |