diff options
| author | Abhinav Gupta <mail@abhinavg.net> | 2021-12-04 15:16:09 -0800 |
|---|---|---|
| committer | Abhinav Gupta <mail@abhinavg.net> | 2021-12-04 15:40:53 -0800 |
| commit | 0dcebfb72bbdaf01554f938402e699d67937c5a0 (patch) | |
| tree | 512b1d1651109b3008ff610cf2abfa8adc1c211b /plumbing/format/gitattributes/attributes.go | |
| parent | e4fcd078d42e945581616855ab78d8b7ed12df6c (diff) | |
| download | go-git-0dcebfb72bbdaf01554f938402e699d67937c5a0.tar.gz | |
error strings: Don't capitalize, use periods, or newlines
Per [Go Code Review Comments][1],
> Error strings should not be capitalized (unless beginning with proper
> nouns or acronyms) or end with punctuation
staticcheck's [ST1005][2] also complains about these. For example,
```
object_walker.go:63:10: error strings should not be capitalized (ST1005)
object_walker.go:101:10: error strings should not be capitalized (ST1005)
object_walker.go:101:10: error strings should not end with punctuation or a newline (ST1005)
plumbing/format/commitgraph/file.go:17:26: error strings should not be capitalized (ST1005)
```
This fixes all instances of this issue reported by staticcheck.
[1]: https://github.com/golang/go/wiki/CodeReviewComments#error-strings
[2]: https://staticcheck.io/docs/checks/#ST1005
Diffstat (limited to 'plumbing/format/gitattributes/attributes.go')
| -rw-r--r-- | plumbing/format/gitattributes/attributes.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/plumbing/format/gitattributes/attributes.go b/plumbing/format/gitattributes/attributes.go index d13c2a9..329e667 100644 --- a/plumbing/format/gitattributes/attributes.go +++ b/plumbing/format/gitattributes/attributes.go @@ -15,7 +15,7 @@ const ( var ( ErrMacroNotAllowed = errors.New("macro not allowed") - ErrInvalidAttributeName = errors.New("Invalid attribute name") + ErrInvalidAttributeName = errors.New("invalid attribute name") ) type MatchAttribute struct { |