diff options
| author | Paulo Gomes <pjbgf@linux.com> | 2023-05-11 21:34:07 +0100 |
|---|---|---|
| committer | Paulo Gomes <pjbgf@linux.com> | 2023-05-11 21:34:07 +0100 |
| commit | 9dfaf6acd8e3aa1c85bcce7d45f8e8c6b908319c (patch) | |
| tree | 58e4dc8c6b2071259eba56169ece9e4cf2c3c93c | |
| parent | dc2b346ed149080199d578f0190f3ac1156480c2 (diff) | |
| download | go-git-9dfaf6acd8e3aa1c85bcce7d45f8e8c6b908319c.tar.gz | |
*: Remove redudant err nil checks
Signed-off-by: Paulo Gomes <pjbgf@linux.com>
| -rw-r--r-- | plumbing/format/idxfile/writer.go | 5 | ||||
| -rw-r--r-- | plumbing/format/packfile/encoder.go | 6 | ||||
| -rw-r--r-- | plumbing/object/rename.go | 5 | ||||
| -rw-r--r-- | remote.go | 6 |
4 files changed, 4 insertions, 18 deletions
diff --git a/plumbing/format/idxfile/writer.go b/plumbing/format/idxfile/writer.go index daa1605..e556013 100644 --- a/plumbing/format/idxfile/writer.go +++ b/plumbing/format/idxfile/writer.go @@ -84,11 +84,8 @@ func (w *Writer) OnFooter(h plumbing.Hash) error { w.checksum = h w.finished = true _, err := w.createIndex() - if err != nil { - return err - } - return nil + return err } // creatIndex returns a filled MemoryIndex with the information filled by diff --git a/plumbing/format/packfile/encoder.go b/plumbing/format/packfile/encoder.go index c9d19b3..804f5a8 100644 --- a/plumbing/format/packfile/encoder.go +++ b/plumbing/format/packfile/encoder.go @@ -131,11 +131,7 @@ func (e *Encoder) entry(o *ObjectToPack) (err error) { defer ioutil.CheckClose(or, &err) _, err = io.Copy(e.zw, or) - if err != nil { - return err - } - - return nil + return err } func (e *Encoder) writeBaseIfDelta(o *ObjectToPack) error { diff --git a/plumbing/object/rename.go b/plumbing/object/rename.go index 0394613..ad2b902 100644 --- a/plumbing/object/rename.go +++ b/plumbing/object/rename.go @@ -741,10 +741,7 @@ func (i *similarityIndex) add(key int, cnt uint64) error { // It's the same key, so increment the counter. var err error i.hashes[j], err = newKeyCountPair(key, v.count()+cnt) - if err != nil { - return err - } - return nil + return err } else if j+1 >= len(i.hashes) { j = 0 } else { @@ -1250,11 +1250,7 @@ func (r *Remote) buildFetchedTags(refs memory.ReferenceStorage) (updated bool, e // operation is complete, an error is returned. The context only affects to the // transport operations. func (r *Remote) ListContext(ctx context.Context, o *ListOptions) (rfs []*plumbing.Reference, err error) { - refs, err := r.list(ctx, o) - if err != nil { - return refs, err - } - return refs, nil + return r.list(ctx, o) } func (r *Remote) List(o *ListOptions) (rfs []*plumbing.Reference, err error) { |