diff options
author | Sascha <GlancingMind@outlook.com> | 2021-03-17 17:54:49 +0100 |
---|---|---|
committer | Sascha <GlancingMind@outlook.com> | 2021-03-19 17:52:03 +0100 |
commit | 9f6c045f8b6e44e47300cec181217906f48d8261 (patch) | |
tree | 37098204e3604e0902473dbdb2be9a4e7835efa5 /webui/src/pages/bug/EditCommentForm.tsx | |
parent | c874d111f50dc129a1ac8210beff626eea2f2186 (diff) | |
download | git-bug-9f6c045f8b6e44e47300cec181217906f48d8261.tar.gz |
Several fixes
- Fix misspelling of cancel...
- Fix flickering of green "update comment" button
- Fill input with comment text
- Close edit view after submit
Diffstat (limited to 'webui/src/pages/bug/EditCommentForm.tsx')
-rw-r--r-- | webui/src/pages/bug/EditCommentForm.tsx | 43 |
1 files changed, 15 insertions, 28 deletions
diff --git a/webui/src/pages/bug/EditCommentForm.tsx b/webui/src/pages/bug/EditCommentForm.tsx index fb192a02..46cf1e1f 100644 --- a/webui/src/pages/bug/EditCommentForm.tsx +++ b/webui/src/pages/bug/EditCommentForm.tsx @@ -8,7 +8,8 @@ import CommentInput from '../../components/CommentInput/CommentInput'; import { BugFragment } from './Bug.generated'; import { useAddCommentMutation } from './CommentForm.generated'; -import { TimelineDocument } from './TimelineQuery.generated'; +import { AddCommentFragment } from './MessageCommentFragment.generated'; +import { CreateFragment } from './MessageCreateFragment.generated'; type StyleProps = { loading: boolean }; const useStyles = makeStyles<Theme, StyleProps>((theme) => ({ @@ -39,37 +40,22 @@ const useStyles = makeStyles<Theme, StyleProps>((theme) => ({ type Props = { bug: BugFragment; - commentId: string; - onCancleClick?: () => void; + comment: AddCommentFragment | CreateFragment; + onCancelClick?: () => void; + onPostSubmit?: () => void; }; -function EditCommentForm({ bug, commentId, onCancleClick }: Props) { +function EditCommentForm({ bug, comment, onCancelClick, onPostSubmit }: Props) { const [addComment, { loading }] = useAddCommentMutation(); - const [issueComment, setIssueComment] = useState(''); + const [issueComment, setIssueComment] = useState<string>(comment.message); const [inputProp, setInputProp] = useState<any>(''); const classes = useStyles({ loading }); const form = useRef<HTMLFormElement>(null); const submit = () => { - addComment({ - variables: { - input: { - prefix: bug.id, - message: issueComment, - }, - }, - refetchQueries: [ - // TODO: update the cache instead of refetching - { - query: TimelineDocument, - variables: { - id: bug.id, - first: 100, - }, - }, - ], - awaitRefetchQueries: true, - }).then(() => resetForm()); + console.log('submit: ' + issueComment); + resetForm(); + if (onPostSubmit) onPostSubmit(); }; function resetForm() { @@ -83,10 +69,10 @@ function EditCommentForm({ bug, commentId, onCancleClick }: Props) { if (issueComment.length > 0) submit(); }; - function getCancleButton() { + function getCancelButton() { return ( - <Button onClick={onCancleClick} variant="contained"> - Cancle + <Button onClick={onCancelClick} variant="contained"> + Cancel </Button> ); } @@ -98,9 +84,10 @@ function EditCommentForm({ bug, commentId, onCancleClick }: Props) { inputProps={inputProp} loading={loading} onChange={(comment: string) => setIssueComment(comment)} + inputText={comment.message} /> <div className={classes.actions}> - {onCancleClick ? getCancleButton() : ''} + {onCancelClick ? getCancelButton() : ''} <Button className={classes.greenButton} variant="contained" |