aboutsummaryrefslogtreecommitdiffstats
path: root/util/colors
diff options
context:
space:
mode:
authorZdenek Crha <zdenek.crha@gmail.com>2020-09-21 12:11:39 +0200
committerZdenek Crha <zdenek.crha@gmail.com>2020-09-27 09:22:34 +0200
commit999e61224c1efe49496d6d84ba255544e74c524a (patch)
tree8aa5099bcb16ef6bf3da2fb3f3fa2730527cf90c /util/colors
parent6bf64841d381460f1e44adecd42132080d07fac9 (diff)
downloadgit-bug-999e61224c1efe49496d6d84ba255544e74c524a.tar.gz
Fix 'no description' readability in terminal with bright background
The rendering of color for 'No description provided' text is broken on bright terminals - it sets black background which together with default black forground color renders opaque rectangle. The GreyBold color alias is broken too - name suggests bold gray forground color, but actually sets bold default fg color with black bacground. First make color alias consistent. Rename it to BlackBold and have it set bold black fg color (same as similar *Bold aliases). Second, update all places which use it to render text to also use white background to prevent it from disappering in terminals with black background color.
Diffstat (limited to 'util/colors')
-rw-r--r--util/colors/colors.go3
1 files changed, 2 insertions, 1 deletions
diff --git a/util/colors/colors.go b/util/colors/colors.go
index f8c6d188..6d2ad35a 100644
--- a/util/colors/colors.go
+++ b/util/colors/colors.go
@@ -5,15 +5,16 @@ import "github.com/fatih/color"
var (
Bold = color.New(color.Bold).SprintFunc()
Black = color.New(color.FgBlack).SprintFunc()
+ BlackBold = color.New(color.FgBlack, color.Bold).SprintfFunc()
BlackBg = color.New(color.BgBlack, color.FgWhite).SprintFunc()
White = color.New(color.FgWhite).SprintFunc()
WhiteBold = color.New(color.FgWhite, color.Bold).SprintFunc()
+ WhiteBg = color.New(color.BgWhite).SprintFunc()
Yellow = color.New(color.FgYellow).SprintFunc()
YellowBold = color.New(color.FgYellow, color.Bold).SprintFunc()
YellowBg = color.New(color.BgYellow, color.FgBlack).SprintFunc()
Green = color.New(color.FgGreen).SprintFunc()
GreenBg = color.New(color.BgGreen, color.FgBlack).SprintFunc()
- GreyBold = color.New(color.BgBlack, color.Bold).SprintfFunc()
Red = color.New(color.FgRed).SprintFunc()
Cyan = color.New(color.FgCyan).SprintFunc()
CyanBg = color.New(color.BgCyan, color.FgBlack).SprintFunc()