diff options
| author | Zdenek Crha <zdenek.crha@gmail.com> | 2020-09-21 12:11:39 +0200 |
|---|---|---|
| committer | Zdenek Crha <zdenek.crha@gmail.com> | 2020-09-27 09:22:34 +0200 |
| commit | 999e61224c1efe49496d6d84ba255544e74c524a (patch) | |
| tree | 8aa5099bcb16ef6bf3da2fb3f3fa2730527cf90c /termui | |
| parent | 6bf64841d381460f1e44adecd42132080d07fac9 (diff) | |
| download | git-bug-999e61224c1efe49496d6d84ba255544e74c524a.tar.gz | |
Fix 'no description' readability in terminal with bright background
The rendering of color for 'No description provided' text is broken on
bright terminals - it sets black background which together with default
black forground color renders opaque rectangle.
The GreyBold color alias is broken too - name suggests bold gray
forground color, but actually sets bold default fg color with black
bacground.
First make color alias consistent. Rename it to BlackBold and have it
set bold black fg color (same as similar *Bold aliases).
Second, update all places which use it to render text to also use white
background to prevent it from disappering in terminals with black
background color.
Diffstat (limited to 'termui')
| -rw-r--r-- | termui/show_bug.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/termui/show_bug.go b/termui/show_bug.go index 6296c445..0710fa34 100644 --- a/termui/show_bug.go +++ b/termui/show_bug.go @@ -378,7 +378,7 @@ func (sb *showBug) renderMain(g *gocui.Gui, mainView *gocui.View) error { // emptyMessagePlaceholder return a formatted placeholder for an empty message func emptyMessagePlaceholder() string { - return colors.GreyBold("No description provided.") + return colors.BlackBold(colors.WhiteBg("No description provided.")) } func (sb *showBug) createOpView(g *gocui.Gui, name string, x0 int, y0 int, maxX int, height int, selectable bool) (*gocui.View, error) { |