repository: remove tie to Bug, improved and reusable testing

- allow the creation of arbitrary Lamport clocks, freeing the way to new entities and removing Bug specific (upper layer) code.
- generalize the memory-only and persisted Lamport clocks behind a common interface
- rework the tests to provide reusable testing code for a Repo, a Clock, a Config, opening a path to add a new Repo implementation more easily
- test previously untested components with those new tests

Note: one problem found during this endeavor is that `identity.Version` also need to store one time + Lamport time for each other Entity (Bug, config, PR ...). This could possibly done without breaking change but it would be much easier to wait for https://github.com/MichaelMure/git-bug-migration to happen.

1 files changed, 2 insertions, 59 deletions

diff --git a/repository/git_test.go b/repository/git_test.go
index de442e39..1b36fd4c 100644
--- a/repository/git_test.go
+++ b/repository/git_test.go
@@ -3,65 +3,8 @@ package repository
 
 import (
 	"testing"
-
-	"github.com/stretchr/testify/assert"
 )
 
-func TestConfig(t *testing.T) {
-	repo := CreateTestRepo(false)
-	defer CleanupTestRepos(t, repo)
-
-	err := repo.LocalConfig().StoreString("section.key", "value")
-	assert.NoError(t, err)
-
-	val, err := repo.LocalConfig().ReadString("section.key")
-	assert.NoError(t, err)
-	assert.Equal(t, "value", val)
-
-	err = repo.LocalConfig().StoreString("section.true", "true")
-	assert.NoError(t, err)
-
-	val2, err := repo.LocalConfig().ReadBool("section.true")
-	assert.NoError(t, err)
-	assert.Equal(t, true, val2)
-
-	configs, err := repo.LocalConfig().ReadAll("section")
-	assert.NoError(t, err)
-	assert.Equal(t, configs, map[string]string{
-		"section.key":  "value",
-		"section.true": "true",
-	})
-
-	err = repo.LocalConfig().RemoveAll("section.true")
-	assert.NoError(t, err)
-
-	configs, err = repo.LocalConfig().ReadAll("section")
-	assert.NoError(t, err)
-	assert.Equal(t, configs, map[string]string{
-		"section.key": "value",
-	})
-
-	_, err = repo.LocalConfig().ReadBool("section.true")
-	assert.Equal(t, ErrNoConfigEntry, err)
-
-	err = repo.LocalConfig().RemoveAll("section.nonexistingkey")
-	assert.Error(t, err)
-
-	err = repo.LocalConfig().RemoveAll("section.key")
-	assert.NoError(t, err)
-
-	_, err = repo.LocalConfig().ReadString("section.key")
-	assert.Equal(t, ErrNoConfigEntry, err)
-
-	err = repo.LocalConfig().RemoveAll("nonexistingsection")
-	assert.Error(t, err)
-
-	err = repo.LocalConfig().RemoveAll("section")
-	assert.Error(t, err)
-
-	_, err = repo.LocalConfig().ReadString("section.key")
-	assert.Error(t, err)
-
-	err = repo.LocalConfig().RemoveAll("section.key")
-	assert.Error(t, err)
+func TestGitRepo(t *testing.T) {
+	RepoTest(t, CreateTestRepo, CleanupTestRepos)
 }