aboutsummaryrefslogtreecommitdiffstats
path: root/bridge/github
diff options
context:
space:
mode:
authorAlexander Scharinger <rng.dynamics@gmail.com>2021-12-04 09:43:46 +0100
committerAlexander Scharinger <rng.dynamics@gmail.com>2021-12-04 09:50:24 +0100
commit160ba2420b0d09b744d96c102f863134a6f8cfd8 (patch)
treece2f42e55e2c5aa01221bec22024da97143c5a21 /bridge/github
parent1eaf3ec0cb0de9de5bbf1d4f5131e22837740ec5 (diff)
downloadgit-bug-160ba2420b0d09b744d96c102f863134a6f8cfd8.tar.gz
Fix: github import, some issue titles cause error
Diffstat (limited to 'bridge/github')
-rw-r--r--bridge/github/import.go20
1 files changed, 9 insertions, 11 deletions
diff --git a/bridge/github/import.go b/bridge/github/import.go
index a41083d2..5d18bd19 100644
--- a/bridge/github/import.go
+++ b/bridge/github/import.go
@@ -195,12 +195,11 @@ func (gi *githubImporter) ensureIssue(ctx context.Context, repo *cache.RepoCache
}
// At Github there exist issues with seemingly empty titles. An example is
- // https://github.com/NixOS/nixpkgs/issues/72730 .
- // The title provided by the GraphQL API actually consists of a space followed by a
- // zero width space (U+200B). This title would cause the NewBugRaw() function to
- // return an error: empty title.
- title := string(issue.Title)
- if title == " \u200b" { // U+200B == zero width space
+ // https://github.com/NixOS/nixpkgs/issues/72730 (here the title is actually
+ // a zero width space U+200B).
+ // Set title to some non-empty string, since git-bug does not accept empty titles.
+ title := text.CleanupOneLine(string(issue.Title))
+ if text.Empty(title) {
title = EmptyTitlePlaceholder
}
@@ -375,12 +374,11 @@ func (gi *githubImporter) ensureTimelineItem(ctx context.Context, repo *cache.Re
}
// At Github there exist issues with seemingly empty titles. An example is
- // https://github.com/NixOS/nixpkgs/issues/72730 .
- // The title provided by the GraphQL API actually consists of a space followed
- // by a zero width space (U+200B). This title would cause the NewBugRaw()
- // function to return an error: empty title.
+ // https://github.com/NixOS/nixpkgs/issues/72730 (here the title is actually
+ // a zero width space U+200B).
+ // Set title to some non-empty string, since git-bug does not accept empty titles.
title := text.CleanupOneLine(string(item.RenamedTitleEvent.CurrentTitle))
- if title == " \u200b" { // U+200B == zero width space
+ if text.Empty(title) {
title = EmptyTitlePlaceholder
}