aboutsummaryrefslogtreecommitdiffstats
path: root/libbe/util/encoding.py
diff options
context:
space:
mode:
authorW. Trevor King <wking@drexel.edu>2009-12-15 06:44:20 -0500
committerW. Trevor King <wking@drexel.edu>2009-12-15 06:44:20 -0500
commit89b7a1411e4658e831f5d635534b24355dbb941d (patch)
tree77f84979931ac4bf8bcf14d293154fe29e8491bc /libbe/util/encoding.py
parent380889988b6d7881c4e0b5968053f85676d27211 (diff)
downloadbugseverywhere-89b7a1411e4658e831f5d635534b24355dbb941d.tar.gz
Fixed libbe.command.diff + ugly BugDir.duplicate_bugdir implementation
duplicate_bugdir() works, but for the vcs backends, it could require shelling out for _every_ file read. This could, and probably will, be horribly slow. Still it works ;). I'm not sure what a better implementation would be. The old implementation checked out the entire earlier state into a temporary directory pros: single shell out, simple upgrade implementation cons: wouldn't work well for HTTP backens I think a good solution would run along the lines of the currently commented out code in duplicate_bugdir(), where a VersionedStorage.changed_since(revision) call would give you a list of changed files. diff could work off of that directly, without the need to generate a whole duplicate bugdir. I'm stuck on how to handle upgrades though... Also removed trailing whitespace from all python files.
Diffstat (limited to 'libbe/util/encoding.py')
-rw-r--r--libbe/util/encoding.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/libbe/util/encoding.py b/libbe/util/encoding.py
index dcc41f8..7706105 100644
--- a/libbe/util/encoding.py
+++ b/libbe/util/encoding.py
@@ -72,7 +72,7 @@ def get_file_contents(path, mode='r', encoding=None, decode=False):
encoding = get_filesystem_encoding()
f = codecs.open(path, mode, encoding)
else:
- f = open(path, mode)
+ f = open(path, mode)
contents = f.read()
f.close()
return contents