diff options
| author | W. Trevor King <wking@drexel.edu> | 2008-11-22 19:45:37 -0500 |
|---|---|---|
| committer | W. Trevor King <wking@drexel.edu> | 2008-11-22 19:45:37 -0500 |
| commit | 4a626e67b3f401b8e242a55571a802147123a196 (patch) | |
| tree | e5907e6e16e9110a092d723e43f34571a4cac378 /libbe/diff.py | |
| parent | 9524d061aa93451a282f45150944878d6b5cf065 (diff) | |
| download | bugseverywhere-4a626e67b3f401b8e242a55571a802147123a196.tar.gz | |
Explicit rcs.cleanup() in bugdir test.
Don't use del(rcs), because if there was an error, there is still a
reference to rcs in the traceback, so it is never cleaned up. This
can leave the external archive cluttering up your Arch install if
you're using the Arch backend. See the __del__ documentation
http://python.active-venture.com/ref/customization.html#l2h-175
for details.
Also fixed some out-of-date method names in libbe.diff
Diffstat (limited to 'libbe/diff.py')
| -rw-r--r-- | libbe/diff.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libbe/diff.py b/libbe/diff.py index 95d5607..470a864 100644 --- a/libbe/diff.py +++ b/libbe/diff.py @@ -87,11 +87,11 @@ def bug_changes(old, new, bugs): change_strings = ["%s: %s -> %s" % f for f in change_list] for comment_id in new_comment_ids: if comment_id not in old_comment_ids: - summary = comment_summary(new.get_comment(comment_id), "new") + summary = comment_summary(new.comment_root.comment_from_uuid(comment_id), "new") change_strings.append(summary) for comment_id in old_comment_ids: if comment_id not in new_comment_ids: - summary = comment_summary(new.get_comment(comment_id), "removed") + summary = comment_summary(new.comment.root.comment_from_uuid(comment_id), "removed") change_strings.append(summary) if len(change_strings) == 0: |