diff options
| author | Aaron Bentley <abentley@panoramicfeedback.com> | 2006-07-19 10:04:27 -0400 |
|---|---|---|
| committer | Aaron Bentley <abentley@panoramicfeedback.com> | 2006-07-19 10:04:27 -0400 |
| commit | 906ef74e2e941794df5297b5622be58d8c352e50 (patch) | |
| tree | 867281a404356a2df7489505ecb3d8c42d066ab5 | |
| parent | f58a77a5a720de90036cbfd070d06bdc82055283 (diff) | |
| download | bugseverywhere-906ef74e2e941794df5297b5622be58d8c352e50.tar.gz | |
Use Popen.communicate instead of reading the individual streams (why needed?)
| -rw-r--r-- | .bzrignore | 4 | ||||
| -rw-r--r-- | libbe/rcs.py | 5 |
2 files changed, 6 insertions, 3 deletions
@@ -2,3 +2,7 @@ Bugs-Everywhere-Web/beweb/config.py ./build Bugs-Everywhere-Web/beweb/database.sqlite Bugs-Everywhere-Web/beweb/catwalk-session +*.pyc +*.~1~ +*.sw[pon] +*.shelf diff --git a/libbe/rcs.py b/libbe/rcs.py index ac96734..e7097aa 100644 --- a/libbe/rcs.py +++ b/libbe/rcs.py @@ -45,9 +45,8 @@ class CommandError(Exception): self.status = status def invoke(args, expect=(0,)): - q = Popen(args, stdin=PIPE, stdout=PIPE, stderr=PIPE) - output = q.stdout.read() - error = q.stderr.read() + q = Popen(args, stdout=PIPE, stderr=PIPE) + output, error = q.communicate() status = q.wait() if status not in expect: raise CommandError(error, status) |