diff options
author | W. Trevor King <wking@drexel.edu> | 2010-03-19 07:18:13 -0400 |
---|---|---|
committer | W. Trevor King <wking@drexel.edu> | 2010-03-19 07:18:13 -0400 |
commit | 83cdb4afa89cb6ef5dc29561cb89ebd869336503 (patch) | |
tree | a49b07a2e0330bba55a1ad143319be93e4c92355 | |
parent | 3f7057dabf71bd390171e66729f5798758ca8f03 (diff) | |
parent | dc65985ae0602779d9d0de02d3749b8d6e58ab13 (diff) | |
download | bugseverywhere-83cdb4afa89cb6ef5dc29561cb89ebd869336503.tar.gz |
Merged Anton Batenev's report of Nicolas Alvarez' unicode-in-be-new bug
5 files changed, 97 insertions, 0 deletions
diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/comments/2a51d90a-d47e-4a67-abe7-cce19c1eafad/body b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/comments/2a51d90a-d47e-4a67-abe7-cce19c1eafad/body new file mode 100644 index 0000000..3195bea --- /dev/null +++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/comments/2a51d90a-d47e-4a67-abe7-cce19c1eafad/body @@ -0,0 +1,21 @@ +> $ be new 'utf8 string' +> Traceback (most recent call last): +> ... +> UnicodeDecodeError: 'ascii' codec can't decode byte 0xd0 in position 95: ordinal not in range(128) + +(bug reported against cjb@laptop.org-20091006145647-kqkmoh481tl5hvt4) + +This was fixed with revision + wking@drexel.edu-20091117145118-jltbju9thsn5xvkv +in my branch on Nov. 17, 2009. + +> I think it is more correct to use UTF-8 everywhere or use +> locale.getdefaultlocale() instead sys.getdefaultencoding(). + +We try to use unicode strings internally, it's input/output that's +difficult. This particular bug turned out to be related to our +mapfile storage handling. Take a look at the be.unicode-hg branch +leading up to revision + wking@drexel.edu-20091117145118-jltbju9thsn5xvkv +for details. + diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/comments/2a51d90a-d47e-4a67-abe7-cce19c1eafad/values b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/comments/2a51d90a-d47e-4a67-abe7-cce19c1eafad/values new file mode 100644 index 0000000..c79c578 --- /dev/null +++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/comments/2a51d90a-d47e-4a67-abe7-cce19c1eafad/values @@ -0,0 +1,11 @@ +Author: W. Trevor King <wking@drexel.edu> + + +Content-type: text/plain + + +Date: Fri, 19 Mar 2010 11:16:16 +0000 + + +In-reply-to: 854eec21-2eeb-4ed4-af35-7a4a2e1f2e98 + diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/comments/854eec21-2eeb-4ed4-af35-7a4a2e1f2e98/body b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/comments/854eec21-2eeb-4ed4-af35-7a4a2e1f2e98/body new file mode 100644 index 0000000..2a05cbd --- /dev/null +++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/comments/854eec21-2eeb-4ed4-af35-7a4a2e1f2e98/body @@ -0,0 +1,40 @@ +When I try to create bug with utf8 string I get error: + +$ be new 'utf8 string' +Traceback (most recent call last): + File "/usr/bin/be", line 64, in <module> + sys.exit(cmdutil.execute(args[0], args[1:])) + File "/usr/lib/python2.6/site-packages/libbe/cmdutil.py", line 82, in execute + manipulate_encodings=manipulate_encodings) + File "/usr/lib/python2.6/site-packages/becommands/new.py", line 54, in execute + bug = bd.new_bug(summary=summary.strip()) + File "/usr/lib/python2.6/site-packages/libbe/bugdir.py", line 584, in new_bug + bg.save() + File "/usr/lib/python2.6/site-packages/libbe/bug.py", line 388, in save + self.save_settings() + File "/usr/lib/python2.6/site-packages/libbe/bug.py", line 373, in save_settings + mapfile.map_save(self.vcs, path, self._get_saved_settings()) + File "/usr/lib/python2.6/site-packages/libbe/mapfile.py", line 110, in map_save + vcs.set_file_contents(path, contents, allow_no_vcs) + File "/usr/lib/python2.6/site-packages/libbe/vcs.py", line 354, in set_file_contents + f.write(contents) + File "/usr/lib/python2.6/codecs.py", line 686, in write + return self.writer.write(data) + File "/usr/lib/python2.6/codecs.py", line 351, in write + data, consumed = self.encode(object, self.errors) +UnicodeDecodeError: 'ascii' codec can't decode byte 0xd0 in position 95: ordinal not in range(128) +--- + +$ python +Python 2.6.1 (r261:67515, Jan 8 2010, 16:07:38) +[GCC 4.3.2] on linux2 +Type "help", "copyright", "credits" or "license" for more information. +>>> import sys +>>> import locale +>>> sys.getdefaultencoding() +'ascii' +>>> locale.getdefaultlocale() +('ru_RU', 'UTF-8') + +I think it is more correct to use UTF-8 everywhere or use locale.getdefaultlocale() instead sys.getdefaultencoding(). + diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/comments/854eec21-2eeb-4ed4-af35-7a4a2e1f2e98/values b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/comments/854eec21-2eeb-4ed4-af35-7a4a2e1f2e98/values new file mode 100644 index 0000000..68e1d55 --- /dev/null +++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/comments/854eec21-2eeb-4ed4-af35-7a4a2e1f2e98/values @@ -0,0 +1,8 @@ +Author: Anton Batenev <abbat@abbat> + + +Content-type: text/plain + + +Date: Tue, 16 Mar 2010 12:53:45 +0000 + diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/values b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/values new file mode 100644 index 0000000..5dda50d --- /dev/null +++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/b3562f08-ad27-4b9f-8d21-8b58ba6d9eac/values @@ -0,0 +1,17 @@ +creator: Anton Batenev <abbat@abbat> + + +reporter: Anton Batenev <abbat@abbat> + + +severity: minor + + +status: fixed + + +summary: UTF-8 problems + + +time: Tue, 16 Mar 2010 12:40:01 +0000 + |