| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Improve rendering of changes in multiline messages
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If you update a line with hdata_update and pass a string containing
newlines, the buffer will become a bit broken when bare display mode is
activated (alt+l). It seems that the newlines are printed in bare mode,
but extra lines are not inserted, so the lines are overlapping with each
other.
Fixes #306
|
| |
| |
| |
| |
| |
| |
| | |
Not sure if this can happen. The weechat documentation doesn't state
that it can, but since the if condition was there, maybe it can. If it
can and does happen, abort the modification, which is better than
something unexpected happening.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously, if a multiline message was edited or reacted to, all of the
new message would be crammed into the last line of the already printed
message.
This change updates each line separately, so if the number of lines in
the message doesn't change, the message will still be rendered correctly
after edits or reactions.
If the number of lines change, the rendering is still improved, however
I don't know if it is possible to insert or delete lines in a weechat
buffer without re-rendering the whole buffer, so it won't be perfect. If
the number of lines of a message decreases after an edit, the extra
lines will still be present, but they will be blanked. If the number of
lines increases, the first lines will be set as normally, but the last
line will contain all of the rest of the lines.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Instead of only updating the last line printed with the id of the
message (ts.minor, set in the date_printed field), update all of the
lines that is printed for that message.
This is necessary for updating all of the lines on changes, instead of
only the last. This will be implemented in the next commit.
This assumes that the lines after the first in messages always has an
empty prefix, and that the first line of a message always has a prefix.
This holds for the messages I have seen (single-line, multi-line as well
as me-messages and joins/quits).
Other approaches I considered was to count the number of newlines in the
message and update the same number of lines, or to check the existing
date_printed field of the messages and update the ones that had 10
digits or more (since current timestamps has that, and the slack id
currently has 6 digits). However, I dropped them in favor of the prefix
solution which seems better.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Instead of just checking that bot_id is not None, check that it exists
in the list of bots. This prevents a KeyError when trying to access a
bot that doesn't exist in the list.
This KeyError would happen if you use a reminder. The message from
slackbot then has bot_id B01 which is not in the list of bots from
rtm.start and gives bot_not_found if trying to look it up with the
bots.info API endpoint.
By ignoring the bot_id we fall back to the user/username, which in the
case of reminders is slackbot, so the name appears just as the other
messages from slackbot.
Fixes #420
|
|/
|
|
|
|
| |
We have to replace the & before we replace < and >, otherwise the & in
< and > are going to be replaced. Additionally, we need to end the
sequences with ; which was missing.
|
|\ |
|
| | |
|
| | |
|
| |
| |
| |
| | |
Closes: #315
|
|\|
| |
| | |
Put users in groups according to presence
|
| |
| |
| |
| | |
Fixes #398
|
|\ \
| | |
| | | |
Fix AttributeError on /slack status in team buffer
|
| | | |
|
|\ \ \
| | | |
| | | | |
Set correct number of unread messages in hotlist
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
While the commit 6718e2f fixed buffers not appearing in the hotlist,
after it the number of new messages for each buffer was gone. This makes
the number of messages for each buffer shown again.
|
|\ \ \ \
| | | | |
| | | | | |
Fix opening thread buffers
|
| |/ / / |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Similar syntax as for adding reactions:
3s/foo/bar/
Fixes: #153
|
|/ / /
| | |
| | |
| | | |
Not sure this actually matters as weechat seemed happy with the wrong return codes too
|
|/ /
| |
| |
| |
| | |
Signed-off-by: Ben Kelly <bk@ancilla.ca>
Signed-off-by: Ben Kelly <btk@google.com>
|
|\ \
| | |
| | | |
Don't send typing notifications for threads, since Slack doesn't like that
|
| | |
| | |
| | |
| | | |
Signed-off-by: Ben Kelly <btk@google.com>
|
| | |
| | |
| | |
| | | |
Fixes #80 (again)
|
| | |
| | |
| | |
| | |
| | |
| | | |
Send * to the current channel.
Fixes: #191
|
| |/
|/| |
|
| | |
|
| | |
|
| | |
|
|/ |
|
|\
| |
| | |
Disable formatting for messages with `mrkdwn` unset
|
| |
| |
| |
| |
| | |
Signed-off-by: Ben Kelly <btk@google.com>
Signed-off-by: Ben Kelly <bk@ancilla.ca>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Not everything that needed to be mocked out was, and there was also an
issue with every instance of PluginConfig sharing the same mutable
settings field and thus stomping on each other if you initialized more
than one in the same test.
Signed-off-by: Ben Kelly <bk@ancilla.ca>
Signed-off-by: Ben Kelly <btk@google.com>
|
|/
|
|
|
| |
Signed-off-by: Ben Kelly <btk@google.com>
Signed-off-by: Ben Kelly <bk@ancilla.ca>
|
|\
| |
| | |
Add italic support, and settings to switch between italic and underline
|
| |
| |
| |
| |
| | |
Signed-off-by: Ben Kelly <btk@google.com>
Signed-off-by: Ben Kelly <bk@ancilla.ca>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In weechat 1.5, the info name 'irc_nick_color_name' was renamed to
'nick_color_name'. Since we want to support weechat < 1.5 and don't want
deprecation warnings in >= 1.5, we need to check the version and use the
appropriate name.
Fixes #364
|
| |
| |
| |
| |
| | |
This is going to be used another place in the script in the next commit,
so set a more verbose name so it's not confused with the script version.
|
| | |
|
|\ \
| | |
| | | |
Clean up a little bit
|
| | |
| | |
| | |
| | | |
This doesn't seem to be used, so just remove it.
|
| | |
| | |
| | |
| | | |
The cache is gone, remove some related code.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Today I learned that sometimes, rather than the key missing, it has the value
None. In this case, (key in dict) is true!
This fixes an issue where, if the backscroll of a channel contained such a
message, it would throw while fetching the backscroll and cut off without
fetching all of it.
Signed-off-by: Ben Kelly <btk@google.com>
Signed-off-by: Ben Kelly <bk@ancilla.ca>
|
|\ \ \
| | | |
| | | | |
Add command for setting Slack Status
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This encodes everything sent into weechat, and decodes the return
values, so we don't have to do it every place we call weechat. We still
have to decode the arguments in all of the callback functions though.
The encode_to_utf8 and decode_from_utf8 functions traverses data
structures and encodes/decodes all of the strings inside the structures.
|