| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
I forgot to make some required changes in the tests after commit f3d880e
and commit 49d481c.
|
|
|
|
|
|
|
| |
12 seconds is a bit more than twice the amount of time between the pings
we send.
Fixes #238, fixes #480, fixes #561
|
|
|
|
|
|
| |
This mainly adds team, channel_general and user_alice as fixtures, so we
can use those directly instead of picking arbitrary ones from the lists.
It also adds assertions to some tests which where missing it.
|
|
|
|
| |
These tests don't do any assertions, so they are not very useful.
|
|
|
|
|
|
|
| |
Python 3 receives unicode strings as arguments in weechat callbacks,
websocet receive etc. and we can send unicode strings to weechat
functions, websocket etc., so we don't need to do any of this
converting.
|
|
|
|
|
|
| |
PluginConfig uses round-tripping through wee_slack.w to coerce
the its default values to the correct type. Without this, the normal
getters fail, as '' cannot be converted to an integer/boolean.
|
|
|
|
|
| |
This is compatible with python 3, which StringIO from StringIO or
cStringIO is not.
|
| |
|
|
|
|
| |
Comments are updated as well as live code.
|
|
|
|
|
| |
It seems pointless to serialize request metadata first with pickle, then
pack it into json, just to unpack both afterwards.
|
|
|
|
|
| |
This test doesn't do any assertions, and is as far as I can see
completely useless.
|
|
|
| |
Add @user-groups with tab-completion. @user-groups will be unfurl into format <!subteam^{ID}|handle> message before sending message via linktext method.
|
|
|
|
| |
This parameter is not used in the function.
|
|
|
|
| |
Previously, when writing e.g. `@channel: test` the colon would be lost.
|
| |
|
| |
|
|
|
|
| |
* fixes #618
|
|
|
|
| |
Simplifies the usage so we don't have to look it up each time.
|
|
|
|
|
|
|
|
| |
* Fix for #570, also incorporates #545
* Fixes from the review
* review fix #2
|
| |
|
|\
| |
| | |
Add support for shared channels
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since shared channels only work with the new conversations API, a new
class of SlackChannel and API type were added to support them. Also
`rtm.start` doesn't include external users so their information needs to
be fetched individually when getting the channel history.
To distinguish external users from team members their nicks get appended
with an asterisk, which can be changed with a new setting. They also
appear in a new "External" group in the nicklist since their presences
can't be fetched with `users.getPresence`.
Unfortunately `conversations.history` doesn't include thread messages so
threads won't show up in shared channels.
|
| |
| |
| |
| |
| | |
These missing callbacks are not really errors or exceptions, and we
don't need to implement all of them. Raising an exception makes the
users think something isn't working, and is confusing.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* print `image_url` if it exists
* add test for image_url
* requirements.txt for pytest
* fix requirements.txt
* text before image_url
* this isn’t required
* README readability for development section
thanks @trygveaa
* README reorder for this development section
|
|
|
|
| |
Fixes: #428
|
|\
| |
| | |
feat: Remove Slacks auto prefixing of url protocols
|
| | |
|
|\ \
| | |
| | | |
Attachment tests and minor fixes
|
| | |
| | |
| | |
| | |
| | |
| | | |
The title and from_url fields of attachments doesn't seem to be escaped,
so the check if they already are in the text didn't work if the link
contained e.g. an ampersand.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is a follow-up of commit 0345ba1. That prevented rendering the link
if it already was in the text. This prevents rendering both the
title_link and from_url if they are equal, but not in the text. In this
case it only renders the title_link.
|
| |/ |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
So we can assert on all of the return values. Since True == 1 in python,
this doesn't change the value of WEECHAT_RC_OK.
|
|/
|
|
|
|
| |
Split out the parts of topic_command_cb that's most interesting and
easiest to test into parse_topic_command and add tests for that
function.
|
|\
| |
| | |
Fix broken tests
|
| |
| |
| |
| | |
As far as I can see, this isn't used anywhere.
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
The commit 6718e2f added some more events to the queue when a buffer is
created. This made some tests fail as it would process these events
instead of the ones added in the tests. Fix it by processing all events
in the queue when setting up the eventrouter for the tests.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Setting up the eventrouter for the tests involves code that requires
the config object to be set, so it has to depend on mock_weechat.
This didn't cause a problem when all the tests were run since the first
test depends on mock_weechat so it would be set up. However, if you
tried to run a single test that depended on realish_eventrouter, but not
mock_weechat, it would fail.
|
|\ \
| |/
|/| |
Fix overzealous regex in unfurl_refs
|
| |
| |
| |
| |
| |
| | |
This tests the bug that was fixed in commit c667bf6, where a message
that first has an url and then a > character would try to unfurl
everything up to the last >.
|
| | |
|
|/
|
|
|
|
| |
We have to replace the & before we replace < and >, otherwise the & in
< and > are going to be replaced. Additionally, we need to end the
sequences with ; which was missing.
|
|
|
|
|
|
|
|
|
|
| |
Not everything that needed to be mocked out was, and there was also an
issue with every instance of PluginConfig sharing the same mutable
settings field and thus stomping on each other if you initialized more
than one in the same test.
Signed-off-by: Ben Kelly <bk@ancilla.ca>
Signed-off-by: Ben Kelly <btk@google.com>
|
|
|
|
| |
Signed-off-by: Ben Kelly <btk@google.com>
|
| |
|
|
|
|
|
| |
This provides nicer granular test cases rather than one whole test that
fails.
|