Don't add fallback if link exists in text_before

We should only use the fallback if we don't get any information out of
the attachment. For links that exists in text_before, we have gotten the
information from the attachment, but choose not to display it so we
don't end up with duplicate links. Therefore, we shouldn't use the
fallback in this case.

1 files changed, 24 insertions, 0 deletions

diff --git a/_pytest/test_unwrap_attachments.py b/_pytest/test_unwrap_attachments.py
index 1c5fa86..3c8ac8b 100644
--- a/_pytest/test_unwrap_attachments.py
+++ b/_pytest/test_unwrap_attachments.py
@@ -153,6 +153,30 @@ import pytest
     },
     {
         'input_message': {'attachments': [{
+            'fallback': 'Fallback',
+            'title_link': 'http://link',
+        }]},
+        'input_text_before': "http://link",
+        'output': "",
+    },
+    {
+        'input_message': {'attachments': [{
+            'fallback': 'Fallback',
+            'from_url': 'http://link',
+        }]},
+        'input_text_before': "http://link",
+        'output': "",
+    },
+    {
+        'input_message': {'attachments': [{
+            'fallback': 'Fallback',
+            'image_url': 'http://link',
+        }]},
+        'input_text_before': "http://link",
+        'output': "",
+    },
+    {
+        'input_message': {'attachments': [{
             'title': 'Title',
             'fields': [{
                 'title': 'First field title',