diff options
| author | Trygve Aaberge <trygveaa@gmail.com> | 2020-07-06 15:42:05 +0200 |
|---|---|---|
| committer | Trygve Aaberge <trygveaa@gmail.com> | 2020-07-06 15:59:08 +0200 |
| commit | 3d050458497f4ce97d6586fc7f9006abd242e773 (patch) | |
| tree | 63dd3a02b326a54a8939b21039c94431f680bce4 | |
| parent | 480319843b80dbdbf2bcf3959c14715862fb80ea (diff) | |
| download | wee-slack-3d050458497f4ce97d6586fc7f9006abd242e773.tar.gz | |
Revert "Don't set no_highlight for backlog messages"
This caused a problem for relay clients. They are not notified when
print hooks are disabled/enabled, so they have to use the tags and line
properties to determine if a line should notify.
One could argue that they should not notify when notify_none is present,
even if it's a highlight, but this is not how the hotlist or default
beep trigger in weechat behaves. When a message with a highlight is
printed, that is added to the hotlist and beeps even if notify_none is
set (wee-slack removes the buffer from the hotlist immediately after
printing the line, which is why that wasn't a problem in plain weechat).
Additionally, this caused messages you had reacted to to be highlighted
when the buffer was reprinted, since the text now included your name
when the line was printed.
This reverts commit de5eb518fda26fed3b5cd41c20b064c04020bbb9.
| -rw-r--r-- | wee_slack.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/wee_slack.py b/wee_slack.py index c27b20b..5378683 100644 --- a/wee_slack.py +++ b/wee_slack.py @@ -4050,7 +4050,7 @@ def format_nick(nick, previous_nick=None): def tags_set_notify_none(tags): notify_tags = {"notify_highlight", "notify_message", "notify_private"} tags = [tag for tag in tags if tag not in notify_tags] - tags += ["notify_none"] + tags += ["no_highlight", "notify_none"] return tags @@ -4071,7 +4071,7 @@ def tag(ts, tagset=None, user=None, self_msg=False, backlog=False, no_log=False, if self_msg or backlog: tags = tags_set_notify_none(tags) if self_msg: - tags += ["self_msg", "no_highlight"] + tags += ["self_msg"] if backlog: tags += ["logger_backlog"] if no_log: |