Added a unit test for bug #146313.

3 files changed, 75 insertions, 1 deletions

diff --git a/todo b/todo
index 04e6424..68c6895 100644
--- a/todo
+++ b/todo
@@ -6,5 +6,4 @@ todo list
 - Add a 'doc' builder to the SConstruct to build the module's documentation
 - Rewrite the exiv2 command-line tool and the test binaries in Python and (Python) scripts to run the same tests that are run to test exiv2
 - Write a complete documentation for the binding and it uses
-- Write unit tests (http://docs.python.org/lib/module-unittest.html)
 - New architecture and support of XMP metadata (see bug #183337)
diff --git a/unittest/Bug146313_TestCase.py b/unittest/Bug146313_TestCase.py
new file mode 100644
index 0000000..202884f
--- /dev/null
+++ b/unittest/Bug146313_TestCase.py
@@ -0,0 +1,73 @@
+#!/usr/bin/python
+# -*- coding: utf-8 -*-
+
+# ******************************************************************************
+#
+# Copyright (C) 2006-2007 Olivier Tilloy <olivier@tilloy.net>
+#
+# This file is part of the pyexiv2 distribution.
+#
+# pyexiv2 is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# pyexiv2 is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with pyexiv2; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, 5th Floor, Boston, MA 02110-1301 USA.
+#
+#
+# File:      Bug146313_TestCase.py
+# Author(s): Olivier Tilloy <olivier@tilloy.net>
+#
+# ******************************************************************************
+
+import unittest
+import os.path
+import pyexiv2
+
+class Bug146313_TestCase(unittest.TestCase):
+
+    """
+    Test case for bug #146313.
+
+    Summary: Passing the filename to the Image constructor as unicode fails.
+    Description: passing a unicode string to the constructor of pyexiv2.Image
+    throws an exception of type Boost.Python.ArgumentError.
+    Fix: fixed with revision 76.
+    """
+
+    def testNormalStringAscii(self):
+        """
+        Test passing the constructor a normal string with ascii characters only.
+        """
+        filename = os.path.join('data', 'smiley1.jpg')
+        image = pyexiv2.Image(filename)
+
+    def testNormalStringExotic(self):
+        """
+        Test passing the constructor a normal string with unicode characters.
+        """
+        filename = os.path.join('data', 'bug146313_šmiléŷ.jpg')
+        image = pyexiv2.Image(filename)
+
+    def testUnicodeStringAscii(self):
+        """
+        Test passing the constructor a unicode string with ascii characters
+        only.
+        """
+        filename = unicode(os.path.join('data', 'smiley1.jpg'), 'utf-8')
+        image = pyexiv2.Image(filename)
+
+    def testUnicodeStringExotic(self):
+        """
+        Test passing the constructor a unicode string with unicode characters.
+        """
+        filename = unicode(os.path.join('data', 'bug146313_šmiléŷ.jpg'), 'utf-8')
+        image = pyexiv2.Image(filename)
+
diff --git a/unittest/TestsRunner.py b/unittest/TestsRunner.py
index 1e1ac6b..3d6611d 100755
--- a/unittest/TestsRunner.py
+++ b/unittest/TestsRunner.py
@@ -32,12 +32,14 @@ import unittest
 # Test cases to run
 from RationalTestCase import RationalTestCase
 from ReadMetadataTestCase import ReadMetadataTestCase
+from Bug146313_TestCase import Bug146313_TestCase
 
 if __name__ == '__main__':
     # Instantiate a test suite containing all the test cases
     suite = unittest.TestSuite()
     suite.addTest(unittest.defaultTestLoader.loadTestsFromTestCase(RationalTestCase))
     suite.addTest(unittest.defaultTestLoader.loadTestsFromTestCase(ReadMetadataTestCase))
+    suite.addTest(unittest.defaultTestLoader.loadTestsFromTestCase(Bug146313_TestCase))
     # Run the test suite
     unittest.TextTestRunner(verbosity=2).run(suite)