From 386d70b32810ee1090f13d0944310eb93a0ba0fc Mon Sep 17 00:00:00 2001 From: Ingo Schwarze Date: Wed, 6 Feb 2019 21:11:43 +0000 Subject: Let roff_getname() end the roff identifier at a tab character and audit all its callers whether termination is handled correctly. Resulting improvements: * An escape or tab ending the macro name in a macro invocation is discarded, and argument processing is started after it. * An escape or tab ending a name in ".if d" and ".if r" is preserved. * An escape ending a name in ".ds" causes the whole request to be ignored. * A tab ending a name in ".ds" becomes part of the string. * An escape or tab ending a name in ".rm" causes the rest of the line to be ignored. * An escape or tab ending the first name in ".als", ".rn", or ".nr" causes the whole request to be ignored. Kurt Jaeger made me aware of https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235456#c0 and in that bug report, comment 0 item (3) is a special case of this class of issues. Yes, the "mh" manual pages are no doubt among the worst on the planet. --- regress/roff/ds/tab.in | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 regress/roff/ds/tab.in (limited to 'regress/roff/ds/tab.in') diff --git a/regress/roff/ds/tab.in b/regress/roff/ds/tab.in new file mode 100644 index 00000000..b96cc155 --- /dev/null +++ b/regress/roff/ds/tab.in @@ -0,0 +1,10 @@ +.\" $OpenBSD: tab.in,v 1.1 2019/02/06 20:54:28 schwarze Exp $ +.Dd $Mdocdate$ +.Dt DS-TAB 1 +.Os +.Sh NAME +.Nm ds-tab +.Nd tab characters in string definition lines +.Sh DESCRIPTION +.ds teststr myval +>>\*[teststr]<< -- cgit