From feb386c64b508cc5bd8206298625ac7d79cbf93b Mon Sep 17 00:00:00 2001 From: Ingo Schwarze Date: Fri, 3 Apr 2015 23:19:15 +0000 Subject: Vastly simplify man(7) block unwinding, similar to mdoc_macro.c 1.171. Drop one enum type, two static functions, 70 lines of code. Also fixes the mpeg_encode(1) manual reported broken by naddy@. --- man_macro.c | 151 +++++++++++++----------------------------------------------- 1 file changed, 33 insertions(+), 118 deletions(-) (limited to 'man_macro.c') diff --git a/man_macro.c b/man_macro.c index d030360f..ffea89d1 100644 --- a/man_macro.c +++ b/man_macro.c @@ -31,24 +31,13 @@ #include "libmandoc.h" #include "libman.h" -enum rew { - REW_REWIND, - REW_NOHALT, - REW_HALT -}; - static void blk_close(MACRO_PROT_ARGS); static void blk_exp(MACRO_PROT_ARGS); static void blk_imp(MACRO_PROT_ARGS); static void in_line_eoln(MACRO_PROT_ARGS); static int man_args(struct man *, int, int *, char *, char **); - -static void rew_scope(enum roff_type, struct man *, int); -static enum rew rew_dohalt(int, enum roff_type, - const struct roff_node *); -static enum rew rew_block(int, enum roff_type, - const struct roff_node *); +static void rew_scope(struct man *, int); const struct man_macro __man_macros[MAN_MAX] = { { in_line_eoln, MAN_NSCOPED }, /* br */ @@ -154,119 +143,46 @@ man_unscope(struct man *man, const struct roff_node *to) MAN_NEXT_CHILD : MAN_NEXT_SIBLING; } -static enum rew -rew_block(int ntok, enum roff_type type, const struct roff_node *n) -{ - - if (type == ROFFT_BLOCK && n->parent->tok == ntok && - n->parent->type == ROFFT_BODY) - return(REW_REWIND); - return(ntok == n->tok ? REW_HALT : REW_NOHALT); -} - -/* - * There are three scope levels: scoped to the root (all), scoped to the - * section (all less sections), and scoped to subsections (all less - * sections and subsections). - */ -static enum rew -rew_dohalt(int tok, enum roff_type type, const struct roff_node *n) -{ - enum rew c; - - /* We cannot progress beyond the root ever. */ - if (n->type == ROFFT_ROOT) - return(REW_HALT); - - assert(n->parent); - - /* Normal nodes shouldn't go to the level of the root. */ - if (n->parent->type == ROFFT_ROOT) - return(REW_REWIND); - - /* Already-validated nodes should be closed out. */ - if (MAN_VALID & n->flags) - return(REW_NOHALT); - - /* First: rewind to ourselves. */ - if (type == n->type && tok == n->tok) { - if (man_macros[n->tok].fp == blk_exp) - return(REW_HALT); - else - return(REW_REWIND); - } - - /* - * Next follow the implicit scope-smashings as defined by man.7: - * section, sub-section, etc. - */ - - switch (tok) { - case MAN_SH: - break; - case MAN_SS: - /* Rewind to a section, if a block. */ - if (REW_NOHALT != (c = rew_block(MAN_SH, type, n))) - return(c); - break; - case MAN_RS: - /* Preserve empty paragraphs before RS. */ - if (0 == n->nchild && (MAN_P == n->tok || - MAN_PP == n->tok || MAN_LP == n->tok)) - return(REW_HALT); - /* Rewind to a subsection, if a block. */ - if (REW_NOHALT != (c = rew_block(MAN_SS, type, n))) - return(c); - /* Rewind to a section, if a block. */ - if (REW_NOHALT != (c = rew_block(MAN_SH, type, n))) - return(c); - break; - default: - /* Rewind to an offsetter, if a block. */ - if (REW_NOHALT != (c = rew_block(MAN_RS, type, n))) - return(c); - /* Rewind to a subsection, if a block. */ - if (REW_NOHALT != (c = rew_block(MAN_SS, type, n))) - return(c); - /* Rewind to a section, if a block. */ - if (REW_NOHALT != (c = rew_block(MAN_SH, type, n))) - return(c); - break; - } - - return(REW_NOHALT); -} - /* * Rewinding entails ascending the parse tree until a coherent point, * for example, the `SH' macro will close out any intervening `SS' * scopes. When a scope is closed, it must be validated and actioned. */ static void -rew_scope(enum roff_type type, struct man *man, int tok) +rew_scope(struct man *man, int tok) { struct roff_node *n; - enum rew c; - for (n = man->last; n; n = n->parent) { - /* - * Whether we should stop immediately (REW_HALT), stop - * and rewind until this point (REW_REWIND), or keep - * rewinding (REW_NOHALT). - */ - c = rew_dohalt(tok, type, n); - if (REW_HALT == c) - return; - if (REW_REWIND == c) - break; - } + /* Preserve empty paragraphs before RS. */ - /* - * Rewind until the current point. Warn if we're a roff - * instruction that's mowing over explicit scopes. - */ + n = man->last; + if (tok == MAN_RS && n->nchild == 0 && + (n->tok == MAN_P || n->tok == MAN_PP || n->tok == MAN_LP)) + return; - man_unscope(man, n); + for (;;) { + if (n->type == ROFFT_ROOT) + return; + if (n->flags & MAN_VALID) { + n = n->parent; + continue; + } + if (n->type != ROFFT_BLOCK) { + if (n->parent->type == ROFFT_ROOT) { + man_unscope(man, n); + return; + } else { + n = n->parent; + continue; + } + } + if (tok != MAN_SH && (n->tok == MAN_SH || + (tok != MAN_SS && (n->tok == MAN_SS || + man_macros[n->tok].fp == blk_exp)))) + return; + man_unscope(man, n); + n = man->last; + } } @@ -318,7 +234,7 @@ blk_close(MACRO_PROT_ARGS) if (nn == NULL) { mandoc_msg(MANDOCERR_BLK_NOTOPEN, man->parse, line, ppos, man_macronames[tok]); - rew_scope(ROFFT_BLOCK, man, MAN_PP); + rew_scope(man, MAN_PP); } else { line = man->last->line; ppos = man->last->pos; @@ -341,7 +257,7 @@ blk_exp(MACRO_PROT_ARGS) char *p; int la; - rew_scope(ROFFT_BLOCK, man, tok); + rew_scope(man, tok); man_block_alloc(man, line, ppos, tok); man_head_alloc(man, line, ppos, tok); head = man->last; @@ -372,8 +288,7 @@ blk_imp(MACRO_PROT_ARGS) char *p; struct roff_node *n; - rew_scope(ROFFT_BODY, man, tok); - rew_scope(ROFFT_BLOCK, man, tok); + rew_scope(man, tok); man_block_alloc(man, line, ppos, tok); man_head_alloc(man, line, ppos, tok); n = man->last; -- cgit