From 25b0103191a0ceaf99b445cec57298031421d819 Mon Sep 17 00:00:00 2001 From: Ingo Schwarze Date: Sat, 1 Jun 2013 04:56:50 +0000 Subject: If a table contained at least one complete line and on its last line, the first T{ remained unclosed, roff_parseln() never returned ROFF_TBL for that last line, so {man,mdoc}_addspan() never got called for that last line, so we ended up with a table where no line associated with a node had TBL_SPAN_LAST set, so tbl_term() never free()'d the cols in struct roffcol, so tblcalc() crashed on the NULL == tbl->cols assertion when starting the *next* table in the same file. Fix this by returning ROFF_TBL as soon as we open a data cell, not only when finishing it - as explained above, it may never get properly closed but instead be interrupted by .TE. Problem reported by bentley@ in latex2man.1. I love it when bugs take half a day to debug but the fix turns out to be flipping one single bit in the source code. --- tbl_data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tbl_data.c b/tbl_data.c index 54baae99..aa2d43dd 100644 --- a/tbl_data.c +++ b/tbl_data.c @@ -102,7 +102,7 @@ data(struct tbl_node *tbl, struct tbl_span *dp, if (*pos - sv == 2 && 'T' == p[sv] && '{' == p[sv + 1]) { tbl->part = TBL_PART_CDATA; - return(0); + return(1); } assert(*pos - sv >= 0); -- cgit