summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Commit and commit message by deraadt@:Ingo Schwarze2021-11-052-3/+6
| | | | | | | | | | | | | | For open/openat, if the flags parameter does not contain O_CREAT, the 3rd (variadic) mode_t parameter is irrelevant. Many developers in the past have passed mode_t (0, 044, 0644, or such), which might lead future people to copy this broken idiom, and perhaps even believe this parameter has some meaning or implication or application. Delete them all. This comes out of a conversation where tb@ noticed that a strange (but intentional) pledge behaviour is to always knock-out high-bits from mode_t on a number of system calls as a safety factor, and his bewilderment that this appeared to be happening against valid modes (at least visually), but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef. ok millert
* simplify a few accesses to fields of structs, using auxiliary pointerIngo Schwarze2021-10-171-5/+3
| | | | | variables that are already present (and used nearby) in the code; no functional change
* Simplify the code building lists of spans, no output change intended.Ingo Schwarze2021-10-171-6/+7
| | | | | | | | A comment in the code claimed that the list of spans would be sorted, but the sorting did not actually work. The layout "LSSS,LLSL" resulted in the list "0-3, 1-2", whereas the layout "LLSL,LSSS" resulted in the list "1-2, 0-3". Since sorting serves no purpose, just leave the list unsorted.
* better error message if mandocd is not foundIngo Schwarze2021-10-151-1/+1
|
* Clean up memory handling in spawn_pager(), free(3)ing everythingIngo Schwarze2021-10-041-14/+12
| | | | | that is malloc(3)ed. In addition to being less confusing, the new code is also shorter by two lines.
* In man(1) mode, properly clean up the resn[] result arrayIngo Schwarze2021-10-041-0/+7
| | | | | | | | | | after processing each name given on the command line. Failure to do so resulted in a memory leak of about 50 kilobytes per name given on the command line. Since man(1) uses a few Megabytes of memory anyway and people rarely give hundreds of names on the command line, this leak did not cause practical problems, but cleaning up properly is better in any case.
* Provide a cleanup function for the term_tab module, freeing memoryIngo Schwarze2021-10-043-8/+20
| | | | | | | | | | and resetting the internal state to the initial state. Call this function from the proper place in term_free(). With the way the module is currently used, this does not imply any functional change, but doing proper cleanup is more robust, makes it easier during code review to understand what is going on, and makes it explicit that there is no memory leak.
* store the operating system name obtained from uname(3) in the adequateIngo Schwarze2021-10-043-7/+8
| | | | | | struct together with similar state date rather than in a function-scope static variable, such that it can be free(3)d in roff_man_free(); no functional change
* Do not leak 64 bytes of heap memory every time a manual page callsIngo Schwarze2021-10-041-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | a user-defined macro. Calls of standard mdoc(7) and man(7) macros were unaffected, so the effect on OpenBSD manual pages was small, about 80 Kilobytes grand total for a full run of "makewhatis /usr/share/man". Argument expansion contexts for user-defined macros are stored on a stack that grows as needed if calls of user-defined macros are nested or recursive. Individual stack entries contain dynamically allocated arrays of pointers to arguments; these argument arrays also grow as needed if user-defined macros take more than eight arguments. The mistake was that argument arrays of already initialized expansion contexts were leaked rather than reused on subsequent macro calls. I found this issue in a systematic hunt for memory leaks after Michael <Stapelberg at Debian> reported memory exhaustion problems on the production server manpages.debian.org. This sub-Megabyte leak is not the cause of Michael's trouble, though, where Gigabytes of memory are being wasted. We are still investigating whether the original problem may be related to his supervisor process, which is written in Go, rather than to mandoc.
* tagging issues from weerd@ regarding hyphensIngo Schwarze2021-10-011-0/+11
|
* Revert part of the previous diff to fix a regression (another endless loop)Ingo Schwarze2021-09-281-3/+17
| | | | | | | | | reported by Michael <Stapelberg at Debian> in the Linux md(4) manual. The reason the colwidth[] array is needed is not that it stores widths different from those in tbl->cols[].width, but that only part of the columns participate in the comparisons, i.e. only those intersecting at least one span the still requires width distribution.
* two typos; patch from Raf Czlonka <rczlonka at gmail dot com>Ingo Schwarze2021-09-281-2/+2
|
* Sevan Janiyan resigned from the NetBSD project and pkgsrc in 2020.Ingo Schwarze2021-09-251-1/+1
| | | | He is now busy with the early stages of development of Viewpoint Linux.
* release 1.14.6VERSION.1.14.6Ingo Schwarze2021-09-231-1/+1
|
* credits for release testingIngo Schwarze2021-09-231-9/+16
|
* handle man3c/fopen.3c in main.c/fs_*()Ingo Schwarze2021-09-211-0/+5
|
* POSIX make(1) does not support prerequisites on suffix rules.Ingo Schwarze2021-09-211-2/+2
| | | | | | | | | | | For HTML generation, the "mandoc" prerequisite isn't needed anyway because ${WWW_MANS} already explicitly depends on mandoc. Issue reported by Sevan Janiyan and Leah Neukirchen. This is not critical for release because it is only used for a maintainer target. While here, i also fixed the associated shell command to use the freshly built mandoc binary rather than whatever may be in the $PATH.
* more details about Mac OS X; information from Sevan JaniyanIngo Schwarze2021-09-202-5/+12
|
* make the path to ar(1) configurable, needed by NixOS;Ingo Schwarze2021-09-203-2/+9
| | | | suggested by Lukas Epple <sternenseemann at systemli dot org>
* Create the link from ./man to ./mandoc in the "all" target rather thanIngo Schwarze2021-09-201-2/+2
| | | | | | in the "regress" target. That makes manual "cd regress && ./regress.pl" a bit less fragile. The idea came up in a conversation with Thomas Klausner <wiz at NetBSD>.
* isspace(3) requires an unsigned argument;Ingo Schwarze2021-09-191-3/+3
| | | | bug reported by Thomas Klausner <wiz at NetBSD>
* clarify the meaning of a complicated mixed signed/unsigned expression;Ingo Schwarze2021-09-191-1/+1
| | | | Thomas Klausner <wiz at NetBSD> reported a compiler warning
* do not ship with an old OpenBSD version numberIngo Schwarze2021-09-191-1/+1
|
* some more portability improvementsIngo Schwarze2021-09-191-1/+2
|
* Test availability of mkstemps(3) and provide a fallback implementationIngo Schwarze2021-09-195-2/+88
| | | | in case it is missing; needed for SUN Solaris 10.
* Two minor improvements:Ingo Schwarze2021-09-191-6/+4
| | | | | | | 1. If mktemp(3) fails, do not overwrite the errno because all errors mktemp(3) might return are also valid for mkdtemp(3). 2. If mkdir(2) fails, always put back the Xes, even if the error is fatal and the function is about to return NULL.
* do not use the echo(1) -n option, it is not portable;Ingo Schwarze2021-09-191-2/+2
| | | | issue found on SUN Solaris 10
* do not use the sed(1) -i option, it is not portable;Ingo Schwarze2021-09-191-5/+6
| | | | issue found on Oracle Solaris 11
* bump VERSIONIngo Schwarze2021-09-191-1/+1
|
* tiny updateIngo Schwarze2021-09-191-1/+1
|
* update some Copyright yearsIngo Schwarze2021-09-191-2/+2
|
* update Makefile.dependIngo Schwarze2021-09-181-1/+1
|
* correct whitespace in the title of the Lesk paper to match the original;Ingo Schwarze2021-09-181-1/+1
| | | | patch from jsg@
* replace "Ar arg Ar arg" with "Ar arg arg"; patch from jmc@Ingo Schwarze2021-09-181-1/+1
|
* document mandoc_recallocarray(3);Ingo Schwarze2021-09-171-9/+28
| | | | patch found in my tree, apparently forgotten years ago
* updateIngo Schwarze2021-09-171-36/+145
|
* Quirk-compatibility with GNU tbl(1):Ingo Schwarze2021-09-101-8/+11
| | | | | | | With the "nospaces" option, skip space characters before and after "T{", in addition to skipping those at the beginning and end of data cells. Minor issue reported by <Oliver dot Corff at email dot de>.
* add two newly reported bugs,Ingo Schwarze2021-09-101-10/+12
| | | | and remove two feature requests that were recently implemented
* In a tbl(7) having the "nospaces" option, skip space charactersIngo Schwarze2021-09-101-0/+3
| | | | | | | not only at the end of data cells, but also after "T}", aligning the behaviour of the parser with GNU tbl(1). Issue reported by <Oliver dot Corff at email dot de>.
* In HTML output, in cells with an "n" (number) layout, pad numbersIngo Schwarze2021-09-091-0/+24
| | | | | | | | | on the right side with UTF-8 punctuation and figure spaces such that numbers in different tbl(7) rows align at the decimal point. The exact HTML output format was suggested by <Oliver dot Corff at email dot de>; the implementation in C is mine.
* If the layout or data of an individual cell in a tbl(7) containsIngo Schwarze2021-09-093-1/+8
| | | | | | | | | | | | | | only "_", "-", or "=", requesting a horizontal line to be drawn across the middle of the cell, print <hr/> in that cell in HTML output. That is arguably slightly ugly because HTML 5 regards <hr/> as semantic markup, meaning "thematic break". If somebody knowns a better way to render a horizontal line across the middle of a table cell with pure HTML and CSS, and without implying a specific meaning, please tell me. Missing feature reported by <Oliver dot Corff at email dot de>.
* Fix an infinite loop that could occur during some cases of horizontallyIngo Schwarze2021-09-071-33/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | overlapping horizontal spans. One span would calculate a desired target width and start preparations for applying it to some columns, then the other span would overwrite the target width with a different value and also start preparations for applying that one to some columns, which could sometimes confuse the code doing the final distribution to the point of not doing anything at all before entering the next iteration. Fix this by making sure the distribution is done step by step, doing one step at a time rather than allowing multiple steps to conflict. Specifically, always do the smallest useful step first. This change also simplifies the code. For example, the local "colwidth" array is no longer needed. Note that the algorithm still differs from the one implemented in GNU tbl(1), which appears to not even try to harmonize column widths but seems to simply distribute the same amount to all constituent columns, no matter whether their intrinsic width is narrow or wide. Adopting a GNU-compatible algorithm might allow further simplifiction in addition to yielding even more similar output, but i do not want to implement any major changes of the algorithm at this time. The infinite loop was reported by <Oliver dot Corff at email dot de>.
* Correctly calculate required column widths for tables containingIngo Schwarze2021-09-073-6/+24
| | | | | | | cells that horizontally span columns which contains "n" (number) formatted cells on other rows. This requires updating total column widths from "n" formatted cells before starting width distribution from the spanning cells to their constituent columns.
* we already parse the GNU tbl(7) "nospaces" option,Ingo Schwarze2021-09-072-9/+18
| | | | so let it have the intended effect, too
* do not crash when a tbl(7) cell uses roman fontIngo Schwarze2021-09-071-0/+2
|
* TODO: let makewhatis(8) follow symbolic links to dirsIngo Schwarze2021-09-061-0/+5
|
* during prioritization for man(1), correctly extract the section nameIngo Schwarze2021-09-041-6/+11
| | | | | | from the file name extension of gzipped manual page files; bug found on Alpine Linux by Soeren Tempel <soeren at soeren hyphen tempel dot net>, who also tested this patch
* mdoc(7): improve output of .At 32vIngo Schwarze2021-09-041-1/+1
| | | | | | | | | | | | | | | | | | | The official designation by AT&T was "UNIX/32V", so use that in the output. That also makes sense because "system/architecture" is a widespread convention to refer to the port of an operating system to a specific architecture, in this case 32V (32bit DEC VAX). The former wording "Version 32V AT&T UNIX" was misleading because 32V is not a version number. Even though UNIX/32V was not officially designated as Version 7 by AT&T, prepend "Version 7" because it was in fact a straightforward port of Version 7 AT&T UNIX. That makes it easier to understand for 21st century readers of manual pages. Suggested by nabijaczleweli at nabijaczleweli dot xyz. Same change as in GNU troff commit 21d30728. OK G dot Branden dot Robinson at gmail dot com (gbranden@ in groff)
* In the fallback code to look for manual pages without using mandoc.db(5),Ingo Schwarze2021-09-041-21/+65
| | | | | | | | | | | | | | | accept files "man<one-digit-section>/<name>.<full-section>" in addition to the already supported "man<full-section>/name.[01-9]*". Needed for example on Alpine Linux which puts its Perl manuals into "man3/<name>.3pm" and the POSIX manuals into "man3/<name>.3p". While here, allow the glob(3) at the end of fs_lookup() to add multiple matches to the result set. This improves man -w output and may also help some cases of plain man(1), allowing main() to prioritize properly rather than fs_lookup() picking a random match. Issue reported and patch tested by Soeren Tempel <soeren at soeren hyphen tempel dot net>.
* do not crash when a manpath directory contains a symbolic linkIngo Schwarze2021-08-191-0/+2
| | | | | | that points to a directory rather than to a regular file; bug reported by Lukas Epple <sternenseemann at systemli dot org>, and my patch also tested by him on NixOS
generated by cgit (git 2.34.1) at 2024-11-20 06:05:45 +0000