summaryrefslogtreecommitdiffstats
path: root/mandocdb.c
diff options
context:
space:
mode:
authorIngo Schwarze <schwarze@openbsd.org>2014-04-23 16:34:50 +0000
committerIngo Schwarze <schwarze@openbsd.org>2014-04-23 16:34:50 +0000
commita7b25cfc2df349d5af8d9f64b781ef9aa16b83e3 (patch)
tree773a732384e7649c5d78a2954378dee87058ddf7 /mandocdb.c
parent842d2c18036af60bbed3a3624ecf8fe100d9d443 (diff)
downloadmandoc-a7b25cfc2df349d5af8d9f64b781ef9aa16b83e3.tar.gz
improve SQL style: avoid "SELECT *", be explicit in what columns we want;
suggested by espie@.
Diffstat (limited to 'mandocdb.c')
-rw-r--r--mandocdb.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/mandocdb.c b/mandocdb.c
index 4025cb5b..9d7534af 100644
--- a/mandocdb.c
+++ b/mandocdb.c
@@ -1287,7 +1287,8 @@ names_check(void)
"AND mlinks.name == names.name"
")"
") JOIN ("
- "SELECT * FROM mlinks GROUP BY pageid"
+ "SELECT sec, arch, name, pageid FROM mlinks "
+ "GROUP BY pageid"
") USING (pageid);",
-1, &stmt, NULL);