diff options
author | Ingo Schwarze <schwarze@openbsd.org> | 2014-07-30 23:01:39 +0000 |
---|---|---|
committer | Ingo Schwarze <schwarze@openbsd.org> | 2014-07-30 23:01:39 +0000 |
commit | d04c6341b9459e49c141ef24f7c7b8956dd53c31 (patch) | |
tree | 9728c344e195419857d3926f0bab8f20cbe89bae /man_validate.c | |
parent | b9959419144200aae35b8cb648937b9bd18a5716 (diff) | |
download | mandoc-d04c6341b9459e49c141ef24f7c7b8956dd53c31.tar.gz |
Improve handling of next-line scope broken by end of file.
Detect the condition earlier, report in the error message
which block is broken, and delete the broken block.
Consequently, empty section headers can no longer happen.
Diffstat (limited to 'man_validate.c')
-rw-r--r-- | man_validate.c | 24 |
1 files changed, 3 insertions, 21 deletions
diff --git a/man_validate.c b/man_validate.c index 3d143b9b..877b7e9d 100644 --- a/man_validate.c +++ b/man_validate.c @@ -62,7 +62,6 @@ static int post_vs(CHKARGS); static int post_fi(CHKARGS); static int post_ft(CHKARGS); static int post_nf(CHKARGS); -static int post_sec(CHKARGS); static int post_TH(CHKARGS); static int post_UC(CHKARGS); static int pre_sec(CHKARGS); @@ -78,7 +77,6 @@ static v_check posts_le1[] = { check_le1, NULL }; static v_check posts_nf[] = { check_eq0, post_nf, NULL }; static v_check posts_par[] = { check_par, NULL }; static v_check posts_part[] = { check_part, NULL }; -static v_check posts_sec[] = { post_sec, NULL }; static v_check posts_sp[] = { post_vs, check_le1, NULL }; static v_check posts_th[] = { check_ge2, check_le5, post_TH, NULL }; static v_check posts_uc[] = { post_UC, NULL }; @@ -88,8 +86,8 @@ static v_check pres_sec[] = { pre_sec, NULL }; static const struct man_valid man_valids[MAN_MAX] = { { NULL, posts_br }, /* br */ { NULL, posts_th }, /* TH */ - { pres_sec, posts_sec }, /* SH */ - { pres_sec, posts_sec }, /* SS */ + { pres_sec, NULL }, /* SH */ + { pres_sec, NULL }, /* SS */ { NULL, NULL }, /* TP */ { NULL, posts_par }, /* LP */ { NULL, posts_par }, /* PP */ @@ -190,12 +188,7 @@ static int check_root(CHKARGS) { - if ((MAN_BLINE | MAN_ELINE) & man->flags) - mandoc_msg(MANDOCERR_BLK_LINE, man->parse, - 0, 0, "at end of file"); - - man->flags &= ~MAN_BLINE; - man->flags &= ~MAN_ELINE; + assert((man->flags & (MAN_BLINE | MAN_ELINE)) == 0); if (NULL == man->first->child) man_nmsg(man, n, MANDOCERR_DOC_EMPTY); @@ -325,17 +318,6 @@ pre_sec(CHKARGS) } static int -post_sec(CHKARGS) -{ - - if ( ! (MAN_HEAD == n->type && 0 == n->nchild)) - return(1); - - man_nmsg(man, n, MANDOCERR_SYNTARGCOUNT); - return(0); -} - -static int check_part(CHKARGS) { |